Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Document new behavior from 5a0307fb #364

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

solj
Copy link
Member

@solj solj commented Oct 2, 2016

We no longer strip() the trailing whitespace from Probe output which can
result in different behavior than previous versions.

Signed-off-by: Sol Jerome sol.jerome@gmail.com

We no longer strip() the trailing whitespace from Probe output which can
result in different behavior than previous versions.

Signed-off-by: Sol Jerome <sol.jerome@gmail.com>
@AlexanderS
Copy link
Member

Is this really an intended change?

Btw: And I cannot find a strip() in the old code. Where was it removed? The only change I found in 5a0307f is in the group handling, that is now using a regexp to match the group names and strip trailing whitespaces in one step.

@AlexanderS
Copy link
Member

Do we really want to document this as change? Or do we want to add a strip() so that the output is like before?

@solj
Copy link
Member Author

solj commented Aug 31, 2017

@AlexanderS I believe it was an intended change so that the probes were technically accurate. In other words, I'm guessing someone had a Probe where they wanted the whitespace to stick around. I prefer the old way but I can see where one might run into problems if they care about the trailing whitespace.

@AlexanderS
Copy link
Member

Maybe we want to strip the output by default, but add the possibility to flag the Probes that shouldn't be striped somehow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants