Split data downloading and building creating #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you think the best long term plan is to keep the download code in the Building class or in some other data fetching class? I’m thinking that if we had some sort of data class with an interface, it could have one version that gets data from the internet and a second that gets data from a file. Let me know if this makes sense, and I don’t even know if JavaScript has interfaces |
|
I think there is no need to make interface. In tests, we can mock fetch(), and the data from the file is literally the second argument of the |
|
Thanks for the input. I must like to over-complicate things 😅 |
Beakerboy
added a commit
that referenced
this pull request
Jun 4, 2025
* Split data downloading and building creating (#118) * Outer building visibility (#119) * Visibility (#120) * Update building.js (#121) * Tests for API (#122) * check HTTP code status and show alert with error * tests for API errors * Show validation errors (#123) * show validation errors + tests * fix typo * Skip incompleted ways, skip non-way members, prevent global modification of way object (#100) * skip non-way members, skip incompleted ways, prevent global modification of Document with way * add test * better colors for MeshPhysicalMaterial (#126) * Fix crash when processing type=building with outline being a multipolygon (#124) * #88 initial support type=building with multipolygon outline * support multiple ways in inner rings * add test * Hipped roof (#128) * Update BuildingShapeUtils.js (#129) * Update BuildingShapeUtils.js (#130) * Update utils.test.js (#132) --------- Co-authored-by: Roman Deev <roman.deev06@gmail.com>
Beakerboy
added a commit
that referenced
this pull request
Jun 8, 2025
* Update BuildingShapeUtils.js * Update utils.test.js * Update utils.test.js * Update buildingpart.test.js * Update BuildingShapeUtils.js * Update buildingpart.test.js * Update from main (#133) * Split data downloading and building creating (#118) * Outer building visibility (#119) * Visibility (#120) * Update building.js (#121) * Tests for API (#122) * check HTTP code status and show alert with error * tests for API errors * Show validation errors (#123) * show validation errors + tests * fix typo * Skip incompleted ways, skip non-way members, prevent global modification of way object (#100) * skip non-way members, skip incompleted ways, prevent global modification of Document with way * add test * better colors for MeshPhysicalMaterial (#126) * Fix crash when processing type=building with outline being a multipolygon (#124) * #88 initial support type=building with multipolygon outline * support multiple ways in inner rings * add test * Hipped roof (#128) * Update BuildingShapeUtils.js (#129) * Update BuildingShapeUtils.js (#130) * Update utils.test.js (#132) --------- Co-authored-by: Roman Deev <roman.deev06@gmail.com> * Update building.test.js * Update buildingpart.js * Fixed direction bug (#136) * Update utils.test.js --------- Co-authored-by: Roman Deev <roman.deev06@gmail.com>
Beakerboy
added a commit
to Mosaic-NFT/OSMBuilding
that referenced
this pull request
Jun 11, 2025
* Hipped roof (Beakerboy#128) * Update BuildingShapeUtils.js (Beakerboy#129) * Update BuildingShapeUtils.js (Beakerboy#130) * Update utils.test.js (Beakerboy#132) * Dev (Beakerboy#137) * Update BuildingShapeUtils.js * Update utils.test.js * Update utils.test.js * Update buildingpart.test.js * Update BuildingShapeUtils.js * Update buildingpart.test.js * Update from main (Beakerboy#133) * Split data downloading and building creating (Beakerboy#118) * Outer building visibility (Beakerboy#119) * Visibility (Beakerboy#120) * Update building.js (Beakerboy#121) * Tests for API (Beakerboy#122) * check HTTP code status and show alert with error * tests for API errors * Show validation errors (Beakerboy#123) * show validation errors + tests * fix typo * Skip incompleted ways, skip non-way members, prevent global modification of way object (Beakerboy#100) * skip non-way members, skip incompleted ways, prevent global modification of Document with way * add test * better colors for MeshPhysicalMaterial (Beakerboy#126) * Fix crash when processing type=building with outline being a multipolygon (Beakerboy#124) * Beakerboy#88 initial support type=building with multipolygon outline * support multiple ways in inner rings * add test * Hipped roof (Beakerboy#128) * Update BuildingShapeUtils.js (Beakerboy#129) * Update BuildingShapeUtils.js (Beakerboy#130) * Update utils.test.js (Beakerboy#132) --------- Co-authored-by: Roman Deev <roman.deev06@gmail.com> * Update building.test.js * Update buildingpart.js * Fixed direction bug (Beakerboy#136) * Update utils.test.js --------- Co-authored-by: Roman Deev <roman.deev06@gmail.com> * Update README.md * Update building.test.js * Update building.test.js * Update building.test.js * Update building.js * Update building.js * Update building.js * Update building.js * Update building.js * Update building.js --------- Co-authored-by: Roman Deev <roman.deev06@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After that, we can write tests that test the work with the API.