Skip to content

Update BuildingShapeUtils.js #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025
Merged

Update BuildingShapeUtils.js #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/extras/BuildingShapeUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,24 @@ class BuildingShapeUtils extends ShapeUtils {
// Initialize objects
const shape = new Shape();
var ref;
var node = [];
const nodes = [];

// Get all the nodes in the way of interest
/** {HTMLCollection} */
const elements = way.getElementsByTagName('nd');

// Get the coordinates of all the nodes and add them to the shape outline.
let first = true;

for (const element of elements) {
ref = element.getAttribute('ref');
node = nodelist[ref];
nodes.push(nodelist[ref]);
}
// If the first and last point are identical, remove the last copy.
if (nodes.length > 1 && nodes[0][0] === nodes[elements.length - 1][0] && nodes[0][1] === nodes[elements.length - 1][1]) {
nodes.pop();
}
let first = true;
for (const node of nodes) {
// The first node requires a different function call.
if (first) {
first = false;
Expand All @@ -37,7 +45,6 @@ class BuildingShapeUtils extends ShapeUtils {
}
return shape;
}

/**
* Check if a way is a closed shape.
*
Expand Down
Loading