Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications screen #1270

Closed
alexandrashelenkova opened this issue Jan 31, 2020 · 7 comments
Closed

Notifications screen #1270

alexandrashelenkova opened this issue Jan 31, 2020 · 7 comments
Assignees
@sinaizd
Labels
design UI wallet

Comments

@alexandrashelenkova
Copy link

alexandrashelenkova commented Jan 31, 2020 •
edited
Loading

Add notifications screen https://zpl.io/awXx1Eg
Notifications types:

  • expired address
  • update available
  • amount sent
  • amount received
  • BEAM news

Badge next to notification's icon should appear only for Update notifications and failed transactions (plus in-app notification for few seconds https://zpl.io/2519rXW). Other notifications types should only be shown as in-app notification.

For Updates, sent, received and failed the app also should show system notification (if possible).
@gingervik
Copy link
Member

For first implementation we need only (for 3 seconds only)

  • update available (without link) with version. Also we should check if user already closed this notification. And we should not show update notification for already updated version
  • currency rates to our Available/Locked/Sending/Receiving panel

@gingervik gingervik mentioned this issue Feb 3, 2020
Closed
@Zeke133 Zeke133 mentioned this issue Feb 14, 2020
Closed
Zeke133 added a commit that referenced this issue Feb 14, 2020
@Zeke133
#1270 #1286 Notifications skeleton
5c3856f
@nesbox nesbox assigned nesbox and unassigned Zeke133 Feb 17, 2020
nesbox added a commit that referenced this issue Feb 18, 2020
@nesbox
#1270: added notification icons
e7f2c0a
nesbox added a commit that referenced this issue Feb 18, 2020
@nesbox
#1270: notifications layout WIP
e521150
nesbox added a commit that referenced this issue Feb 19, 2020
@nesbox
#1270: notifications layout WIP
601bd5a
Zeke133 added a commit that referenced this issue Feb 21, 2020
@Zeke133
#1270 Notifications abstract models
a62139b
nesbox added a commit that referenced this issue Feb 24, 2020
@nesbox
#1270: notifications layout, tiny fixes
ec35185
nesbox added a commit that referenced this issue Feb 27, 2020
@nesbox
#1270: notifications layout, divided to read/unread lists
af63ac6
nesbox added a commit that referenced this issue Feb 27, 2020
@nesbox
#1270: notifications layout, unread notifications badge
4bb3c51
@anatolse anatolse assigned anatolse and unassigned nesbox Mar 2, 2020
anatolse added a commit that referenced this issue Mar 2, 2020
@anatolse
#1270 added read/unread sections
1c5ff4c
anatolse added a commit that referenced this issue Mar 3, 2020
@anatolse
#1270 added ability to remove notifications
a58e089
anatolse added a commit that referenced this issue Mar 3, 2020
@anatolse
#1270 added offsets to notification popup
cdcfb0e
anatolse added a commit that referenced this issue Mar 3, 2020
@anatolse
#1270 implemented notifications counter
71a6348
anatolse added a commit that referenced this issue Mar 3, 2020
@anatolse
#1270 added actions and avoided duplicated popup notifications
aceb788
anatolse added a commit that referenced this issue Mar 3, 2020
@anatolse
#1270 fixed unread section
cd74d84
anatolse added a commit that referenced this issue Mar 4, 2020
@anatolse
#1270 fixed sort order
f667878
anatolse added a commit that referenced this issue Mar 4, 2020
@anatolse
#1270 changed popup timeout and changed unread notifications filter
706e891
@sinaizd
Copy link

sinaizd commented Mar 6, 2020

Please separate the date and time so that they don't look like a single whole.
image

@sinaizd sinaizd assigned anatolse and unassigned sinaizd Mar 6, 2020
anatolse added a commit that referenced this issue Mar 11, 2020
@anatolse
#1270 fixed date | time on notification item
2482976
@Zeke133
Copy link
Contributor

Zeke133 commented Mar 11, 2020

Crash on swap transaction expiration happens.
Swap tx doesn't have PeerID until accepted by the other side.
Swap transactions need special output case.

@Zeke133 Zeke133 self-assigned this Mar 11, 2020
Zeke133 added a commit that referenced this issue Mar 11, 2020
@Zeke133
#1270 crash on swap tx expiration notification output
addc316
@gingervik gingervik assigned sinaizd and unassigned anatolse and Zeke133 Mar 12, 2020
@sinaizd
Copy link

sinaizd commented Mar 12, 2020

Please make a fix according to the screenshot.
image

@sinaizd sinaizd assigned Zeke133 and unassigned sinaizd Mar 12, 2020
@sinaizd
Copy link

sinaizd commented Mar 12, 2020

Also, fix the link when redirecting to the site when the user clicks update in notifications. You need to remove the symbol "#". Correct link https://beam.mw/downloads
image

@anatolse anatolse assigned anatolse and unassigned Zeke133 Mar 13, 2020
anatolse added a commit that referenced this issue Mar 13, 2020
@anatolse
#1270 fixed update link and buttons alignments
a9c1006
@sinaizd sinaizd assigned sinaizd and unassigned anatolse Mar 16, 2020
@sinaizd
Copy link

sinaizd commented Mar 16, 2020

checked

@sinaizd sinaizd closed this as completed Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sinaizd sinaizd

Labels
design UI wallet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@anatolse @nesbox @alexandrashelenkova @gingervik @Zeke133 @sasha-abramovich @sinaizd