Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create swap offer - user should be able to enter rate manually #830

Closed
gingervik opened this issue Aug 29, 2019 · 8 comments
Closed

Create swap offer - user should be able to enter rate manually #830

gingervik opened this issue Aug 29, 2019 · 8 comments
Assignees
Labels
swap ux ux/ui issues or inconsistencies

Comments

@gingervik
Copy link
Member

As it works on exchanges user should be able to enter not only receive and sent amoun but also a rate.
If user enter rate manually one of empty fields (receive or sent) should be filled automatically

@sasha-abramovich @alexandrashelenkova please change design in zeplin and give us link

@sasha-abramovich
Copy link
Contributor

Please attach a screenshot in this and similar issues, we can think from there. Even with some notes please. I want to be sure that we understand each other. Not necessarily new design will be required, it might be as well explained in the same ticket when a screenshot is shown.

@gingervik
Copy link
Member Author

gingervik commented Aug 29, 2019

please, see design. it was not done there https://app.zeplin.io/project/5b379c2c38cb39e73e5f8889/screen/5bd18f9c7eebd309e6c75633

image

@sasha-abramovich
Copy link
Contributor

We can make Rate editable as well. @alexandrashelenkova what do you think?

@alexandrashelenkova
Copy link

Made rate field editable.
Also let's replace Receive amount and Sent amount fields, so when user will change rate, Receive amount should changes as well.
Updates design is here https://zpl.io/VqlKPrm
receive-swap

chapati added a commit that referenced this issue Sep 18, 2019
@gingervik
Copy link
Member Author

  1. When user delete rate receive amount still have number counted as sent amount*last deleted number in rate field
    Please, see attached video
    rate.zip

chapati added a commit that referenced this issue Sep 19, 2019
@gingervik
Copy link
Member Author

  1. Receive amount changes when user enter rate and then move pointer to "receive amount" field
    please, see attached video

receiv.zip

@chapati
Copy link
Member

chapati commented Sep 24, 2019

  1. Receive amount changes when user enter rate and then move pointer to "receive amount" field
    please, see attached video

receiv.zip

Unfortunately this cannot be fixed. User is able to enter arbitrary value for rate, but receive amount should be always rounded to groth. So we allow user to enter any rate but when he leaves the rate field it displays the closest correct rate possible.

In your example you enter 54 BTC and rate of 89 which gives us 0.606741573 beams. This amount is not possible (last 3 should be rounded up to get groth) and the closest rate to get 0.60674157 is 89.000000445

@gingervik
Copy link
Member Author

ok, can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
swap ux ux/ui issues or inconsistencies
Projects
None yet
Development

No branches or pull requests

5 participants