-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create swap offer - user should be able to enter rate manually #830
Comments
Please attach a screenshot in this and similar issues, we can think from there. Even with some notes please. I want to be sure that we understand each other. Not necessarily new design will be required, it might be as well explained in the same ticket when a screenshot is shown. |
please, see design. it was not done there https://app.zeplin.io/project/5b379c2c38cb39e73e5f8889/screen/5bd18f9c7eebd309e6c75633 |
We can make Rate editable as well. @alexandrashelenkova what do you think? |
Made rate field editable. |
|
|
Unfortunately this cannot be fixed. User is able to enter arbitrary value for rate, but receive amount should be always rounded to groth. So we allow user to enter any rate but when he leaves the rate field it displays the closest correct rate possible. In your example you enter 54 BTC and rate of 89 which gives us 0.606741573 beams. This amount is not possible (last 3 should be rounded up to get groth) and the closest rate to get 0.60674157 is 89.000000445 |
ok, can be closed |
As it works on exchanges user should be able to enter not only receive and sent amoun but also a rate.
If user enter rate manually one of empty fields (receive or sent) should be filled automatically
@sasha-abramovich @alexandrashelenkova please change design in zeplin and give us link
The text was updated successfully, but these errors were encountered: