Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI SWAP] Screens do not close after clicking button "publish transaсtion token" \ "send". #928

Closed
sinaizd opened this issue Sep 26, 2019 · 2 comments
Closed

[UI SWAP] Screens do not close after clicking button "publish transaсtion token" \ "send". #928

sinaizd opened this issue Sep 26, 2019 · 2 comments
Assignees
@gingervik
Labels
bug Something isn't working swap

Comments

@sinaizd
Copy link

sinaizd commented Sep 26, 2019 •
edited
Loading

Screens "Swap currencies " \ "Create swap offer" do not close after clicking button "send"(In the alert "Confirmation transaction details") \ "publish translation token".
image
@sinaizd sinaizd added bug Something isn't working swap labels Sep 26, 2019
@sinaizd sinaizd changed the title [UI SWAP] Screens do not close after clicking button "publish translation token" \ "send". [UI SWAP] Screens do not close after clicking button "publish transaсtion token" \ "send". Sep 26, 2019
@Sergei-Beam
Copy link
Member

  1. The bug with Close Create Swap Offer page is fixed in Close Create Swap Offer page on Public Offer click #931

  2. Bug with "Swap currencies " still be actual
    Steps:

  • click accept offer
  • paste the token into Send to field
  • click swap
    Actual: page doesn't close

Zeke133 added a commit that referenced this issue Sep 30, 2019
@Zeke133
#928 Close of send swap oofer view on dialog confirmation
7e53481
@gingervik gingervik assigned gingervik and unassigned Zeke133 Oct 1, 2019
@gingervik
Copy link
Member

checked on master 4.0.6249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gingervik gingervik

Labels
bug Something isn't working swap
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Aleksandr-Starun @gingervik @Zeke133 @Sergei-Beam @sinaizd