Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle decrement method. #62

Merged
merged 3 commits into from
Dec 12, 2017
Merged

Handle decrement method. #62

merged 3 commits into from
Dec 12, 2017

Conversation

alexsegura
Copy link
Contributor

Fixes #61

Still need to add tests.

@alexsegura alexsegura mentioned this pull request Dec 11, 2017
Merged
2 tasks
Oliboy50
Oliboy50 approved these changes Dec 11, 2017
View reviewed changes
CONTRIBUTING.md Outdated
```

And you can now launch tests
```bash
./vendor/bin/atoum
./bin/atoum
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could also remove the ./ to only keep bin/atoum

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@alexsegura
Copy link
Contributor Author

Done.

@omansour @Oliboy50 do you think you can merge this and create a new release? Thanks 😬

Oliboy50
Oliboy50 approved these changes Dec 11, 2017
View reviewed changes
Copy link
Member

@Oliboy50 Oliboy50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we can

You'll just have to wait for a second review before we merge/tag this, but don't worry, I'm pretty sure we'll do :)

Thanks for contributing

@omansour
Copy link
Contributor

v2.15.0

@omansour omansour merged commit f5ca7cb into BedrockStreaming:master Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oliboy50 Oliboy50 Oliboy50 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexsegura @omansour @Oliboy50