Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAWTherapee DJI mini 4 Pro DNG #6995

Closed
RAWimageViewer opened this issue Mar 16, 2024 · 13 comments
Closed

RAWTherapee DJI mini 4 Pro DNG #6995

RAWimageViewer opened this issue Mar 16, 2024 · 13 comments

Comments

@RAWimageViewer
Copy link

ISSUE: DNG photo first loaded into RT 5.10 appears light in center and darker around. This is not the way the JPEG corresponding image appears. Why does the DNG image appears as uneven exposure. This is what happens for all the DNG photos loaded into RT 5.10

DNG RAW photo source: The supplied images are from (screenshots 1 and 2) from a DJI Mini 4 Pro camera set to AUTO and capturing JPEG + RAW photo

  1. RT VERSION:

Version: 5.10
Branch: 5.10
Commit: 8adb543
Commit date: 2024-02-15
Compiler: clang 15.0.0.15000100
Processor: arm64
System: Apple
Bit depth: 64 bits
Gtkmm: V3.24.8
Lensfun: V0.3.4.0
Build type: Release

  1. Apple operating system name and version:

Sonoma 14.4

  1. steps to reproduce

Simply move the photo files from the drone SD card to the laptop computer (Apple M2 Pro processor chip) hard drive and place in a folder. Open RT and then direct RT to that folder to see the photos. Clicking on/selecting a DNG photo results in the center being a brighter part of the image and the surrounding area is darker.

Screenshot 1 DNG has had no edits or corrections, just appears when loaded in preparation to make adjustments.

Screenshot 2 JPG is the same corresponding drone photo when the drone captures a pair of photos (one is JPEG and the other is the RAW DNG photo)

When opening the same DNG file using the Apple PREVIEW function one sees the next screenshot type image:

Screenshot 3

  1. Uploaded files:

Screenshot 1
Screenshot 2
Screenshot 3

GitHub does not allow file types to upload including DNG and pp3:
DNG photo (DJI_20240314104659_0127_D)
Pp3
JPEG photo (DJI_20240314104659_0127_D)
pp3

Added Note: RT does presently include camera settings for some of the DJI drones, but it might be nice to add others like the mini 4 pro. If it helps you, might I contact their technical support team and request they provide you info for the Hasselblad mini 4 pro drone camera?

(Added note2: A similar issue was illustrated by another person on a Reddit comment: https://www.reddit.com/r/dji/comments/17c8hw3/mini_4_pro_editing_dng_with_darktable_or/ )

Screenshot 1 DNG photo
Screenshot  2 JPG photo
Screenshot 3 dng preview

@Lawrence37
Copy link
Collaborator

Duplicate of #6868.

What you are seeing is vignetting. It's especially pronounced in many small sensor cameras like drones and smartphones (in my experience). What are the "camera settings for some of the DJI drones" you are talking about? You can use filebin.net to share large files. GitHub accepts smaller files as long as the extension is supported (rename xyz.pp3 to xyz.pp3.txt or put them in a .zip file before uploading).

@Lawrence37 Lawrence37 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 16, 2024
@RAWimageViewer
Copy link
Author

RAWimageViewer commented Mar 17, 2024 via email

@Lawrence37
Copy link
Collaborator

Thanks for the sample DNG!

There are a few ways to fix vignetting in RawTherapee. For the DJI Mini4 Pro, I think the best options are the manual correction (Transform tab > Lens / Geometry > Vignetting Correction) or flat-field correction (Raw tab > Flat-Field). Manual correction doesn't require any setup. Just "eyeball" the results. The disadvantage is that the correction will not be exact and does not fix any color cast which typical of these kinds of cameras. Flat-field correction gives precise results and also fixes color casts, but requires you to shoot flat-field images. RawPedia has an extensive article on using flat-fields in RawTherapee.

The JPEG looks ok because the vignetting has been corrected in-camera, but not the DNG. The other software you mention are also applying correction because they know the vignette parameters. A note for RawTherapee developers: The DNG contains a GainMap in OpcodeList3 which might be for vignette correction. RawTherapee supports the OpcodeList2 GainMap but not the OpcodeList3 one.

For profiled lens corrections, RawTherapee uses Lensfun. They don't have any data for the DJI Mini4 Pro. If you have the time and equipment, the Lensfun team accepts sample images (see https://lensfun.github.io/calibration/).

@RAWimageViewer
Copy link
Author

RAWimageViewer commented Mar 17, 2024 via email

@Lawrence37
Copy link
Collaborator

Most likely the DNGs already have the information required to fix the vignette. I referenced #6998 which I think will allow RawTherapee to use the vignette data.

For Lensfun, take some time to read through the link. There are a few scenarios that affect what information they need from you. All the instructions are available on that page or in the links on that page.

@RAWimageViewer
Copy link
Author

RAWimageViewer commented Mar 18, 2024 via email

@Lawrence37
Copy link
Collaborator

Your sample image does help and it's possible we need you to upload it again, but I have downloaded it and can share it with other developers if needed. I recommend sharing a sample to raw.pixls.us.The RPU is a collection of raw images from all kinds of cameras. RawTherapee and other FOSS photo software use it to add or improve support for raw image formats.

@RAWimageViewer
Copy link
Author

RAWimageViewer commented Mar 20, 2024 via email

@RAWimageViewer
Copy link
Author

RAWimageViewer commented Mar 20, 2024 via email

@RAWimageViewer
Copy link
Author

RAWimageViewer commented May 30, 2024 via email

@kmilos
Copy link
Contributor

kmilos commented May 31, 2024

something differs between RAWTherapee and darktable

darktable implemented support for DNG OpcodeList3 vignetting: darktable-org/darktable#12880

Note that this is for the FixVignetteRadial opcode only rather than GainMap (also supported only for OpcodeList2).

@sgotti
Copy link
Contributor

sgotti commented May 31, 2024

I'm in the work of porting the various embedded metadata lens corrections from darktable (ART already did this) to Rawtherapee. This also includes the dng opcode3 WarpRectilinear.
I'm using the new Fuji algorithm that I developed for darktable in darktable-org/darktable#14468 (ART uses the old version) and I'm also trying to port the Panasonic distortion corrections. This is probably related to issue #3254.

@Lawrence37 Let me know if I should open a new issue to track this work and future PRs.

@Lawrence37
Copy link
Collaborator

@RAWimageViewer The best way to get updates on the progress is to track the linked issue (#6998).

@sgotti It's a good idea to create issues and self-assign them so people know you are working or planning to work on them before you have enough working code to create a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants