Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactiveSequence #82

Closed
JonasTietz opened this issue Apr 2, 2019 · 6 comments
Closed

ReactiveSequence #82

JonasTietz opened this issue Apr 2, 2019 · 6 comments

Comments

@JonasTietz
Copy link

Hello,
is there a way right now to have a ReactiveSequence, which does not tick the next children of one nodes returns RUNNING. Basically I want the reactive behavior, where the sequence always starts ticking from the beginning (so Sequence and SequenceStart are no option) but I still want the nodes to execute one after another.
Am I missing something or is this a niche usecase, which I schould implement myself?

@miccol
Copy link
Member

miccol commented Apr 3, 2019

Hi Jonas, thank you spotting this.

Am I missing something or is this a niche usecase, which I schould implement myself?

It not a niche usecase but in fact one of the main features of a reactive sequence. The library used to have (reactive) sequence nodes with the behavior you describe. Maybe something changed with the Version 3? @facontidavide.

Probably adding a haltChildren(index + 1); and return NodeStatus::RUNNING; after this case may solve the issue.

case NodeStatus::RUNNING:
{
running_count++;
}break;

@facontidavide
Copy link
Collaborator

Hi @miccol

you are 100% right. That is totally a brain fart from my side. I will fix it

facontidavide added a commit that referenced this issue Apr 3, 2019
@facontidavide
Copy link
Collaborator

Nevertheless, I still need to find a good solution for the problem mentioned in #71, i.e that Reactive nodes can't have multiple asynchronous children...

facontidavide pushed a commit that referenced this issue Apr 3, 2019
@miccol
Copy link
Member

miccol commented Apr 3, 2019

Nevertheless, I still need to find a good solution for the problem mentioned in #71, i.e that Reactive nodes can't have multiple asynchronous children...

I have an idea about that, but it makes some assumptions on the children. Shall we discuss it on a separated issue?

@facontidavide
Copy link
Collaborator

discussion moved to #83

@MarcelSoler
Copy link

Hi!
Something similar is happening to me. I have the following reactive sequence:

image

ExPath return running on the first tick and then is never ticked again... Getpath is ticked properlly all the time (it returns succed).

I am using ros melodic and ros-melodic-behaviortree-cpp-v3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants