Controller Events #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed up the Notification.cs to support a notification with an empty bitmap until we can workout what is causing the icons not to work correctly. Updated test project to pass a notification object to the index.html. In the script tag of the index.html, a simple notification is sent to the headset. Since it is transient, it disapears after a couple seconds.
Added an alpha property to the overlay object to control transparency. Also added a new constructor to allow the passing of an existing overlay key string which will get that overlay and load the object properties. Hany when working with both your own overlays and others that may be present.
Added support for the overlays to work when the controllers are turned on after the application starts. Borrowed some code from the SteamVR Unity Plugin to get the same behavior expected there. It works by registering callbacks for the new device event and prevents the browser from starting until it gets the work from the Overlay that the controllers were found. Otherwise the overlay is created in memory but the browser never starts up.
|
Not sure what that conflict is saying. Maybe you can figure it out. |
|
Just git being a jackass and not merging something easy. Shall look at this later thanks. |
Previous commit and pull request included a misunderstanding on my part about how OpenVR was working, so I am in the middle of trying to fix that now. SteamVR.cs did not need listeners embedded but instead they belonged in SteamVR_WebKit.cs. By calling the SteamVR initialize to attach the listeners, I was inadvertently preventing this from running as an overlay only app. Other games launching were forcing it to quit. Now that it's working again without the SteamVR.cs initialize being called, I need to go through and cleanup SteamVR.cs. I imagine all of the stuff I added last night could be ripped out.
Hand listeners for controller code in teh wrong place. Moved into SteamVR_WebKit.cs and got rid of things that were not needed. As a side note, I am starting to understand OpenVR a bit more. Still feel like I'm bumping around in the dark looking for a light switch though. At least something is working!
|
Is this stable and ready for merge now? |
|
It is stable but it could still use some tweaks to improve it.
Rob
…On Mon, Mar 20, 2017 at 5:27 AM Ben Woodford ***@***.***> wrote:
Is this stable and ready for commit now?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABMroDJS_ASsatxkAY8cTMJDnBrwwfwjks5rnkaXgaJpZM4Ma20i>
.
|
|
Good enough, shall finally merge this :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added controller events