Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not pass event PlayerPortalEvent #583

Closed
YellowZaki opened this issue Feb 26, 2019 · 10 comments
Closed

Could not pass event PlayerPortalEvent #583

YellowZaki opened this issue Feb 26, 2019 · 10 comments
Assignees
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug
Milestone

Comments

@YellowZaki
Copy link
Contributor

Description

Describe the bug

A exception appears in console.
https://pastebin.com/cMMMhVdp

BentoBox: 1.3.0

@YellowZaki YellowZaki added Priority: Medium Status: Pending Waiting for a developer to start working on this issue. Type: Bug labels Feb 26, 2019
@TheWranger
Copy link

When does the error occur?

@YellowZaki
Copy link
Contributor Author

I don't know. I haven't end world enabled but I players have end gates and end portals for decorations.
Prior to 1.3.0 the exception didn't occured.

tastybento added a commit that referenced this issue Feb 26, 2019
This should not occur, but apparently, it can sometimes.

#583
@tastybento tastybento self-assigned this Feb 26, 2019
@tastybento tastybento removed the Status: Pending Waiting for a developer to start working on this issue. label Feb 26, 2019
@tastybento tastybento added this to the 1.4.0 milestone Feb 26, 2019
@tastybento
Copy link
Member

Okay, fixed. I'm not sure why a location in an event can have a null world, but apparently it can. I put in defensive code to avoid any NPE.

@Poslovitch Poslovitch added the Status: Done This issue has been completed or answered. This pull request has been merged. label Feb 26, 2019
@Poslovitch Poslovitch modified the milestones: 1.4.0, 1.3.1 Mar 1, 2019
@akoldfart
Copy link

I also noticed this. It occurs when player enters in or out from non-bentobox nether thru portal. Version 1.3.1

@Poslovitch
Copy link
Member

Do you mean it is still occuring on 1.3.1 ? Can you send us the stacktrace?

@tastybento tastybento reopened this Mar 7, 2019
@tastybento tastybento modified the milestones: 1.3.1, 1.4.0 Mar 7, 2019
tastybento added a commit that referenced this issue Mar 7, 2019
#583

Caused by a failure to check that world was in the known BentoBox worlds
before calling the IWM method.
@tastybento
Copy link
Member

@akoldfart Thanks for the context. This helped fix it properly.

@zaemliss
Copy link

This error seems to be still an issue. running 1.3.1 and getting this:
https://pastebin.com/9Nsm0804

Context: entering a freshly created nether portal from a Multiverse-created world

@AlexiCat
Copy link

I am seeing the same issue on 1.3.1
https://pastebin.com/XbTcAcFY

@tastybento
Copy link
Member

@zaemliss , @AlexiCat you will see it because the fix is on 1.4.0 and not 1.3.1. Please wait until 1.4.0 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug
Projects
None yet
Development

No branches or pull requests

7 participants