Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom end blueprint #771

Closed
AmazedMender16 opened this issue Jun 16, 2019 · 6 comments
Closed

Custom end blueprint #771

AmazedMender16 opened this issue Jun 16, 2019 · 6 comments
Assignees
Labels
1.14 Related to 1.14+ Status: Done This issue has been completed or answered. This pull request has been merged. Type: Not a bug Works as intended / not a BentoBox bug.

Comments

@AmazedMender16
Copy link

Description

Describe the bug

I have a custom end blueprint but it keeps loading the custom one and the default one.
It also keeps prompting me with: https://pastebin.com/XkHeXppf ( there are no signs on my custom island )

  • Edited the default one and removed the sign.. still loads both the blueprints.. my custom one and the default one above eachother

Steps to reproduce the behavior

Create a custom end blueprint, load it and change the json file to use your blueprint.

Expected behavior

Should only load 1 island instead of 2 on top of eachother.

Environment

Server

  • OS: Ubuntu Server 18.04
  • Java version: 1.8.0_212

BentoBox setup

BentoBox and Addons
 Running - SPIGOT 1.14.2.
 BentoBox version - 1.5.3-SNAPSHOT-b1180
 Loaded Game Worlds:
 - sb3-world (Skyblock): Overworld, Nether, End
 Loaded Addons:
 Biomes - 1.5.0.0
 BSkyBlock - 1.5.0
 Challenges - 0.8.0-SNAPSHOT-#272
 Level - 1.5.0
 Limits - 0.2.0-SNAPSHOT
 WelcomeWarps - 1.5.0
Configuration
  • Database: MYSQL

Additional context

@AmazedMender16 AmazedMender16 added Status: Pending Waiting for a developer to start working on this issue. Type: Bug labels Jun 16, 2019
@tastybento tastybento added the 1.14 Related to 1.14+ label Jun 16, 2019
@tastybento
Copy link
Member

I'm a bit confused. What is the name of your custom end island?
Can you share your blueprints folder? (Zip it and drop it in here)

@tastybento tastybento self-assigned this Jun 16, 2019
@tastybento tastybento added Status: Under investigation Investigating the interest and the feasability of the issue. and removed Status: Pending Waiting for a developer to start working on this issue. labels Jun 16, 2019
@AmazedMender16
Copy link
Author

AmazedMender16 commented Jun 16, 2019

Hello,

The name is cn-end-small.blu... nothing special just a different island, it loads both end islands on top of eachother. ( download )

Here you can see what happens :)

@tastybento
Copy link
Member

Hmm. I tried with a fresh install of 1.14.2 and your blueprints folder and it all seemed to work okay. I couldn't get it to double paste like you see. That's a bit weird. Could it be that the End world already has some islands in it maybe? Can you try with a completely fresh server and see if it happens to you still?

@tastybento tastybento added the Status: Cannot replicate Could not replicate the issue on a fresh install. More details are needed. label Jun 18, 2019
@AmazedMender16
Copy link
Author

Hello @tastybento,

Just deleted all the worlds... and the default end blueprint... maybe this will give you some answers.
https://pastebin.com/c3T0tA8M

Regards,
Glenn R.

@BONNe
Copy link
Member

BONNe commented Jun 18, 2019

Do you have bedrock in your blueprint?
It was missing. Solved in discord ;)

Created #777 to avoid this issue happening again.

@Poslovitch Poslovitch added Status: Done This issue has been completed or answered. This pull request has been merged. Type: Not a bug Works as intended / not a BentoBox bug. and removed Status: Cannot replicate Could not replicate the issue on a fresh install. More details are needed. Status: Under investigation Investigating the interest and the feasability of the issue. Type: Bug labels Jun 18, 2019
tastybento added a commit that referenced this issue Jun 18, 2019
Previous check only looked for BEDROCK specifically. Actually, if there
is any block there, it should be true. Admins may accidentally remove
the bedrock and so this is a much safer approach.

#771
@tastybento
Copy link
Member

Aha. I had a worry about that code that checks for bedrock. In ASkyBlock I had it check for any block. I have changed the code there because admins may move bedrock in the future for some reason and it could result in an obliteration like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.14 Related to 1.14+ Status: Done This issue has been completed or answered. This pull request has been merged. Type: Not a bug Works as intended / not a BentoBox bug.
Projects
None yet
Development

No branches or pull requests

4 participants