Static UnpatchAll and UnpatchID #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces some minor overhead in UnpatchAll, but said method should generally not be used anyways.
Renamed to UnpatchConditional to better convey its function
ErisApps
changed the title
nike4613
reviewed
Dec 19, 2021
ErisApps
commented
Dec 19, 2021
bbepis
requested changes
Dec 19, 2021
ghorsington
requested changes
Dec 20, 2021
ghorsington
changed the title
Co-authored-by: Geoffrey Horsington <neigh@coder.horse>
ghorsington
approved these changes
Dec 20, 2021
ManlyMarco
approved these changes
Dec 20, 2021
bbepis
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a continuation following the discussion in PR #40, this PR handles the introduction of 2 (arguably) new static methods
Harmony.UnpatchAll()andHarmony.UnpatchID(string harmonyID).Other than that, it also marks the old non-static
.UnpatchAll(string harmonyID = null)as Obsolete.Not sure how I can verify whether this actually works as intended, but the unit tests seem to run just fine, aside from a seemingly unrelated unit test that was already failing before the changes (
TestTraverse_Types.Traverse_InnerStatic)I think this covers everything that was mentioned in the other PR, but if I missed anything, please let me know.