[Fix] Parallel Request Limiter v3 - use well known redis cluster hashing algorithm #15052
+234
−133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR implements Redis cluster compatibility for the parallel request limiter by using the standard Redis cluster slot calculation algorithm. The changes prevent CROSSSLOT and EVALSHA errors that occur when Redis operations span multiple cluster slots.
- Implements CRC16-based slot calculation algorithm (CRC16(key) mod 16384) following Redis cluster standards
- Adds cluster detection logic to apply slot grouping only when using Redis cluster
- Updates key grouping strategy to use slot numbers instead of hash tags for cluster environments
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| litellm/proxy/hooks/parallel_request_limiter_v3.py | Implements Redis cluster slot calculation and detection logic |
| tests/test_litellm/proxy/hooks/test_parallel_request_limiter_v3.py | Updates tests to cover both regular Redis and cluster scenarios with proper mocking |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ishaan-jaff
added a commit
that referenced
this pull request
Sep 30, 2025
…ing algorithm (#15052) * test_keyslot_for_redis_cluster * fix _is_redis_cluster * Update litellm/proxy/hooks/parallel_request_limiter_v3.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Fix] Parallel Request Limiter v3 - use well known redis cluster hashing algorithm
Fixes LIT-1133
Implements Redis cluster slot calculation in the parallel request limiter to ensure proper key grouping and prevent cross-slot operations in Redis cluster environments.
Relevant issues
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitType
🐛 Bug Fix
✅ Test
Changes