Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag Sexpr Backward/Forward Up/Down deletes immediately preceding/following line comments #1222

Open
PEZ opened this issue Jul 3, 2021 · 0 comments
Labels
bug Something isn't working paredit Paredit and structural editing

Comments

@PEZ
Copy link
Collaborator

PEZ commented Jul 3, 2021

As was demonstrated in this screencast: https://youtu.be/d0K1oaFGvuQ?t=1287

Dragging a form backward up deletes the immediately preceding line comments.

I've tested around a bit and note that this goes for all up/down dragging.

Reproduction. Have the cursor in or adjacent to :backward-up in the following form.

:forward-down
;; forward down
(comment
  ;; backward-up
  :backward-up
  (def foo :foo)
  (def bar :bar)
  :forward-up
  ;; :forward-up
  )
;; backward down
:backward-down

Drag Sexpr Backward Up

Expected:

;; forward down
:backward-up
(comment
  ;; backward-up
  (def foo :foo)
  (def bar :bar)
  :forward-up
  ;; :forward-up
  )
;; backward down
:backward-down

Actual:

;; forward down
:backward-up
(comment
  (def foo :foo)
  (def bar :bar)
  :forward-up
  ;; :forward-up
  )
;; backward down
:backward-down

Dragging the form (def foo :foo)) backward up does not kill the ;; foo line comment.

We have the same bug when dragging all keywords as they are named in the repro text.

@PEZ PEZ added bug Something isn't working paredit Paredit and structural editing labels Jul 3, 2021
@PEZ PEZ changed the title Drag Sexpr Backward/Forward Up deletes immediately preceding/following line comments Drag Sexpr Backward/Forward Up/Down deletes immediately preceding/following line comments Jul 3, 2021
PEZ added a commit that referenced this issue Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working paredit Paredit and structural editing
Projects
None yet
Development

No branches or pull requests

1 participant