-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the Portal Extension #1327
Comments
I've been musing about this in various threads, so since I found an issue, I thought I'd write my two cents here, hope that's OK :) I'm basically looking for a CIDER inspector alternative. With the CIDER inspector, you can essentially drill down and explore a complex value directly within Emacs. AFAICT, CIDER will take the result of the previous nREPL evaluation and load it into the inspector. No configuration necessary. I believe that Portal can take on this role within Calva, serving as the interactive explorer bit, without the user needing to do any configuration. It will be a more limited experience than using Portal "natively" but a huge usability improvement. Here's what I think are the relevant steps:
I hope I'm not misunderstanding how Portal is supposed to work. Notably, you lose the |
I like the idea of having a basic setup that requires zero config on the users part aside from installing some extensions. I think the easiest way to achieve this would be for portal to add a A more decoupled option would be to have calva emit an eval result event that portal could listen to, but I'm not sure how vs-code plumbing works 🤔 As far as |
That's a bit tricky, since we'd have to start a jvm that's running portal. It's possible (that's basically what we do for clojure-lsp) but it means that communication with that portal instance is harder. |
I think that the Portal VS Code extension opens a Node portal, no? |
That's the portal client side. You still need a server that sends stuff over. That's why you still need the portal dependency in your repl, even if you have the portal extension. |
I think a CIDER inspector alternative is needed. Not sure it should be built using Portal, though. Maybe it should, but to me improved Portal support is about the full Portal experience. We should probably have a separate issue for tracking this CIDER inspector alternative need. |
If you have data as EDN, all you need is a HTTP request to send them over to Portal. I have a couple of proof of concepts ready, yay for joyride, I will create a different issue to discuss them though, as per @PEZ wishes. |
Now that there is a Portal Extension for VS Code, Clojure programmers can get an integrated inspector. There are some steps you can take to get this going manually, but we can make it butter smooth if we inject the dependencies and help with starting the Portal session.
The text was updated successfully, but these errors were encountered: