Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select Backward * commands won't grow selection in REPL window #498

Closed
bpringe opened this issue Dec 2, 2019 · 5 comments
Closed

Select Backward * commands won't grow selection in REPL window #498

bpringe opened this issue Dec 2, 2019 · 5 comments
Labels
bug Something isn't working paredit Paredit and structural editing

Comments

@bpringe
Copy link
Member

bpringe commented Dec 2, 2019

A summary:

image
@bpringe bpringe added bug Something isn't working repl-window paredit Paredit and structural editing labels Dec 2, 2019
@bpringe
Copy link
Member Author

bpringe commented Dec 2, 2019

@PEZ I'd like to attempt to fix this, just letting you know.

@PEZ
Copy link
Collaborator

PEZ commented Dec 2, 2019

Nice! I now noticed that after a Grow Selection the next backward selection works. Maybe that is a clue.

@PEZ PEZ mentioned this issue Dec 4, 2019
Merged
10 tasks
@bpringe
Copy link
Member Author

bpringe commented Dec 4, 2019

Just an update here. I believe I have the fix for this and will submit a PR probably later today.

@bpringe bpringe mentioned this issue Dec 5, 2019
Closed
20 tasks
bpringe added a commit that referenced this issue Dec 5, 2019
@bpringe
Fixes #498. Add to changelog
306e647
@PEZ
Copy link
Collaborator

PEZ commented Dec 6, 2019

Right, so with your input it seems this got fixed in #507, we'll see when we have tested it some.

@bpringe
Copy link
Member Author

bpringe commented Feb 1, 2020

This has been fixed. I just verified.

@bpringe bpringe closed this as completed Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working paredit Paredit and structural editing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PEZ @bpringe