Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't change the namespace to user for custom REPL commands #558

Closed
mkarp opened this issue Feb 5, 2020 · 3 comments
Closed

Don't change the namespace to user for custom REPL commands #558

mkarp opened this issue Feb 5, 2020 · 3 comments

Comments

@mkarp
Copy link

mkarp commented Feb 5, 2020

I'd like to request a feature: for custom REPL commands, when ns setting is empty, it would be great if Calva executed the specified command within the current namespace.

Currently Calva always switches to the user namespace.

Staying in the current namespace would be very handy to send (cljs.test/run-tests) to the REPL.

If users need to run a command within the user namespace, they can always specify it in the settings with "ns": "user".

This feature request was briefly discussed in the calva-dev Slack channel https://clojurians.slack.com/archives/CBE668G4R/p1580916516221100

Thank you!

@PEZ
Copy link
Collaborator

PEZ commented Feb 22, 2020

Finally I got around to this. Here's a build with the suggestion (as I understand it) added: https://4041-125431277-gh.circle-artifacts.com/0/tmp/artifacts/calva-2.0.77-dev-d6fba27a.vsix

@PEZ PEZ closed this as completed in d6fba27 Feb 23, 2020
@mkarp
Copy link
Author

mkarp commented Feb 24, 2020

@PEZ Thank you so much for the fix! I've just tried it out and it works exactly how I expected.

@PEZ
Copy link
Collaborator

PEZ commented Feb 24, 2020

Glad you like it! I think it is a big improvement. Don't know why I didn't design it like that to begin with. 😄

PEZ added a commit that referenced this issue Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants