Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve eslint #1529

Merged
merged 11 commits into from
Feb 13, 2022
Merged

Improve eslint #1529

merged 11 commits into from
Feb 13, 2022

Conversation

corasaurus-hex
Copy link
Contributor

@corasaurus-hex corasaurus-hex commented Feb 12, 2022

What has Changed?

This PR is an overhaul of of linting for the project while temporarily keeping it compatible with the current code. The goal is to then turn rules on a few at a time and contribute them as subsequent PRs.

For the reviewer, the general things this PR does are:

  1. Removes tslint, which was deprecated in 2019.
  2. Upgrades the typescript package.
  3. Upgrades some eslint packages.
  4. Removes some other eslint packages.
  5. Adds updated configurations for eslint and typescript.
  6. Adds eslint as a step in in CI.
  7. Changes cp commands in the CI config to use arguments that should work cross-platform.

Fixes #1525

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • Added to or updated docs in this branch, if appropriate
  • Tests
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
    • Smoke tested the extension as such.
    • Tested the VSIX built from the PR (so, after you've submitted the PR). You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on the ci/circleci: build test.
  • Referenced the issue I am fixing/addressing in a commit message for the pull request.
    • If I am fixing the issue, I have used GitHub's fixes/closes syntax
    • [~] If I am fixing just part of the issue, I have just referenced it w/o any of the "fixes” keywords.
  • Created the issue I am fixing/addressing, if it was not present.
  • Formatted all JavaScript and TypeScript code that was changed. (use the prettier extension or run npm run prettier-format)
  • Confirmed that there are no linter warnings or errors (use the eslint extension or run npm run eslint).

Ping @PEZ, @bpringe

@corasaurus-hex
Copy link
Contributor Author

@PEZ and @bpringe : this is ready for review when you get a chance 😎

Copy link
Collaborator

@PEZ PEZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should fix so that we don't need that newline in the changelog, but anyway. =)

CHANGELOG.md Outdated Show resolved Hide resolved
@PEZ PEZ changed the title Wip/improve eslint Improve eslint Feb 12, 2022
Copy link
Collaborator

@PEZ PEZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PEZ PEZ merged commit d253f8d into BetterThanTomorrow:dev Feb 13, 2022
@corasaurus-hex corasaurus-hex deleted the wip/improve-eslint branch February 15, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants