-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve eslint #1529
Merged
PEZ
merged 11 commits into
BetterThanTomorrow:dev
from
corasaurus-hex:wip/improve-eslint
Feb 13, 2022
Merged
Improve eslint #1529
PEZ
merged 11 commits into
BetterThanTomorrow:dev
from
corasaurus-hex:wip/improve-eslint
Feb 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package has been deprecated since 2019 and should not be used.
PEZ
requested changes
Feb 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should fix so that we don't need that newline in the changelog, but anyway. =)
This was referenced Feb 12, 2022
PEZ
approved these changes
Feb 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has Changed?
This PR is an overhaul of of linting for the project while temporarily keeping it compatible with the current code. The goal is to then turn rules on a few at a time and contribute them as subsequent PRs.
For the reviewer, the general things this PR does are:
cp
commands in the CI config to use arguments that should work cross-platform.Fixes #1525
My Calva PR Checklist
I have:
dev
branch. (Or have specific reasons to target some other branch.)published
. (Sorry for the nagging.)[Unreleased]
entry inCHANGELOG.md
, linking the issue(s) that the PR is addressing.ci/circleci: build
test.npm run prettier-format
)npm run eslint
).Ping @PEZ, @bpringe