Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

constraint ocurl version to 0.7.7 #556

Merged
merged 1 commit into from
Sep 19, 2016

Conversation

ivg
Copy link
Member

@ivg ivg commented Sep 19, 2016

It looks like that ocurl.0.7.8 doesn't compile on Ubuntu Precise,
although it works fine at least on the Trusty.

It looks like that ocurl.0.7.8 doesn't compile on Ubuntu Precise,
although it works fine at least on the Trusty.
@hcarty
Copy link

hcarty commented Sep 19, 2016

This may be worth submitting upstream - several other libcurl features are already wrapped behind version checks. Something new may have been introduced and be in need of such a check.

@ivg ivg merged commit 729712e into BinaryAnalysisPlatform:master Sep 19, 2016
@ivg
Copy link
Member Author

ivg commented Sep 19, 2016

@hcarty, yep, but I doubt, that I will have enough time to do this in the nearest future. Also, the opam packaging of the ocurl can be done better, with a proper conf-curl that will be versioned, so that we can explicitly constraint ocurl versions with the curl versions.

@hcarty
Copy link

hcarty commented Sep 19, 2016

Do you mind if I submit an issue to the ocurl project bringing up the 12.04 compatibility issue, linking to this PR?

@ivg ivg deleted the fix-ocurl-version branch October 4, 2016 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants