Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bold & Italics not working #606

Closed
whippingdot opened this issue Sep 10, 2021 · 6 comments
Closed

Bold & Italics not working #606

whippingdot opened this issue Sep 10, 2021 · 6 comments
Labels
bug WIP Work In Process

Comments

@whippingdot
Copy link

Describe the bug
I think I remember when I first used the theme there used to be bold highlighting for function names and italics for comments or something like that right? For the last few months I haven't seen any bold or italic highlighting in my C++ code, or Python code I think, and I was wondering if you could see if it was an error in the theme or if something was wrong on my end and you knew how to fix it. Thanks for the help BTW!

To Reproduce
Steps to reproduce the behavior:

  1. Enable Bold on some Scopes
  2. Enable Italic on some Scopes
  3. Watch and see that there is no bold or italic anywhere (I don't even know what vivid colors does but that also might not be working)

Expected behavior
I expect to see bold colors in function names and in other places, and italic code in some places like comments or something else too (whatever is supposed to happen normally)

Screenshots & Example Code
image
image

Desktop (please complete the following information):

  • OS: [Windows]
  • VSCODE Version [1.61.0-insiders]
  • Theme version [3.11.4]
@Binaryify Binaryify added the WIP Work In Process label Sep 13, 2021
Binaryify added a commit that referenced this issue Sep 19, 2021
#605, Add variables colors settings #605, One Dark Pro Flat/One Dark Pro Darker support set Bold & Italics #606 , Support Inlay hints #603
@Binaryify
Copy link
Owner

One Dark Pro Flat/One Dark Pro Darker didn't support set bold& italics before
v3.12.0 support that
could you try https://github.com/Binaryify/OneDark-Pro/blob/feedback/onedarkpro-3.12.0.vsix before I publish it to the vscode's marketplace?
I need some feedback

@Binaryify
Copy link
Owner

image
image

you can use this to install the vsix

@whippingdot
Copy link
Author

installed it, reloaded editor multiple times, yet I don't seem to have bold or anything still.

@whippingdot
Copy link
Author

No wait it works now, the bold is very hard to see so I didn't notice. NOICE!

BTW it is hard to see for me cause i have a small font size lol.

Binaryify added a commit that referenced this issue Sep 30, 2021
@Binaryify
Copy link
Owner

@whippingdot this extension had a data reference problem, it make setting change sometime don't work, it should be normal after v3.13.0

@whippingdot
Copy link
Author

whippingdot commented Sep 30, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug WIP Work In Process
Projects
None yet
Development

No branches or pull requests

2 participants