Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new rsat version 20240507, tested in local Docker #570

Merged
merged 12 commits into from
May 13, 2024
Merged

new rsat version 20240507, tested in local Docker #570

merged 12 commits into from
May 13, 2024

Conversation

eead-csic-compbio
Copy link
Contributor

This PR adds a new version of the Docker BioContainer with the RSAT software, which now ships wit the code corresponding to tag 20240507 in source repo (https://github.com/rsa-tools/rsat-code). Accordingly, the Dockerfile now contains LABEL software.version="20240507".

The two main updates are:

  • The container can now be run non-interactively, it has been tested in local Docker.
  • install-organisms has been updated to support again the installation of genomes from the NCBI. It was tested by @jvanheld was tested by installing bacterial genomes on the Bacterial RSAT server.

Example non-interactive calls would be:

docker run -v $PWD:/home/rsat_user -v $PWD/out:/home/rsat_user/out rsat:20240507 peak-motifs -i test.fa -outdir out -prefix test

docker run -v $PWD:/home/rsat_user -v $PWD/out:/home/rsat_user/out rsat:20240507 peak-motifs -i test.fa -outdir out -prefix test -motif_db footDB transfac /packages/rsat/public_html/motif_databases/footprintDB/footprintDB.plants.motif.tf

Note the examples require binding two folders:

  1. The current folder from where the container is called ($PWD). This allows processing any FASTA file in the current directory.
  2. The folder to save the results (out/). This should point to an existing local folder where anybody can write (chmod 777).

@medinaale @morganeTC @najlaksouri

@eead-csic-compbio
Copy link
Contributor Author

Hi @ievarau, please use this PR to add any comments you might have during your tests

@ievarau
Copy link

ievarau commented May 8, 2024

  • Tested building. Success. Important to build using Docker (Podman won't do).
  • Tested running container non-interactively with two example calls provided above. Works as expected.
  • Tested within Snakemake pipeline. Works as expected as well.

All in all, peak-motifs with this container version works as expected.

@biocontainers-bot
Copy link
Collaborator

No test-cmds.txt (test file) present, skipping tests

@eead-csic-compbio
Copy link
Contributor Author

This PR is read y to be reviewed by somebody from BioContainers, thanks

@mboudet mboudet self-assigned this May 9, 2024
@eead-csic-compbio
Copy link
Contributor Author

Hi @mboudet , please let us know if there's anything you need from us

@mboudet
Copy link
Contributor

mboudet commented May 13, 2024

Sorry for the delay, last week was mostly bank holidays here.

One quick question: any reason for installing git in a separate apt-get install step? (Ie line 91 instead of 43)
(This is not blocking, just for curiosity).

@eead-csic-compbio
Copy link
Contributor Author

Sorry for the delay, last week was mostly bank holidays here.

One quick question: any reason for installing git in a separate apt-get install step? (Ie line 91 instead of 43) (This is not blocking, just for curiosity).

I guess it was to make it clear that the installation of RSAT would be done using git

@mboudet mboudet merged commit a82dd67 into BioContainers:master May 13, 2024
1 check passed
@mboudet
Copy link
Contributor

mboudet commented May 13, 2024

Alright. Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants