Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip blank lines and comment lines #14

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

CiaranOMara
Copy link
Member

@CiaranOMara CiaranOMara commented Apr 2, 2022

This PR:

  • adds references to the BEDv1 specification to the documentation.
  • adds comment and blank lines to the state machine.

Closes #13.

@CiaranOMara CiaranOMara marked this pull request as ready for review April 2, 2022 10:34
@edmundmiller
Copy link

New to Julia question, why does it think those pieces of code aren't covered?

@CiaranOMara
Copy link
Member Author

CiaranOMara commented Apr 3, 2022

@emiller88, for that particular new code, it probably doesn't get hit because it's in an anonymous function that immediately returns its result. So, it's never called except when the state machines are made.

Copy link

@edmundmiller edmundmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, this looks good to me! Not sure if my review has any weight, but just trying to get involved!

@CiaranOMara CiaranOMara merged commit 5dcf0f1 into BioJulia:develop Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip comments in BED files
2 participants