Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rand!([::AbstractRNG], ::LongSequence, [::Sampler]) methods #250

Merged
merged 2 commits into from
Jul 15, 2022

Conversation

jakobnissen
Copy link
Member

I had apparently forgotten about those before.
Also refactor the old code a bit to make it easier to reason about.

I had apparently forgotten about those before.
Also refactor the old code a bit to make it easier to reason about.
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #250 (fac7d40) into master (8d015fd) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #250      +/-   ##
==========================================
+ Coverage   88.75%   88.77%   +0.01%     
==========================================
  Files          30       30              
  Lines        2322     2325       +3     
==========================================
+ Hits         2061     2064       +3     
  Misses        261      261              
Flag Coverage Δ
unittests 88.77% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/longsequences/randseq.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d015fd...fac7d40. Read the comment docs.

@jakobnissen jakobnissen marked this pull request as ready for review July 15, 2022 13:34
@jakobnissen
Copy link
Member Author

This should be good to go. I'm merging as soon as tests pass - I can't imagine anyone would have anything against this change.

@jakobnissen jakobnissen mentioned this pull request Jul 15, 2022
@jakobnissen jakobnissen merged commit f2536a6 into BioJulia:master Jul 15, 2022
@jakobnissen jakobnissen deleted the rand! branch July 16, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant