Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to Random.GLOBAL_RNG #265

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

jakobnissen
Copy link
Member

This object is undocumented internals, and is replaced by default_rng().

This object is undocumented internals, and is replaced by default_rng().
@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Base: 88.54% // Head: 91.22% // Increases project coverage by +2.68% 🎉

Coverage data is based on head (829b572) compared to base (1cfea08).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
+ Coverage   88.54%   91.22%   +2.68%     
==========================================
  Files          31       31              
  Lines        2330     2394      +64     
==========================================
+ Hits         2063     2184     +121     
+ Misses        267      210      -57     
Flag Coverage Δ
unittests 91.22% <100.00%> (+2.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/longsequences/randseq.jl 100.00% <100.00%> (ø)
src/BioSequences.jl 100.00% <0.00%> (ø)
src/search/re.jl 87.13% <0.00%> (+0.96%) ⬆️
src/search/ApproxSearchQuery.jl 96.77% <0.00%> (+1.07%) ⬆️
src/bit-manipulation/bit-manipulation.jl 84.61% <0.00%> (+1.92%) ⬆️
src/bit-manipulation/bitindex.jl 88.23% <0.00%> (+2.94%) ⬆️
src/alphabet.jl 88.23% <0.00%> (+3.52%) ⬆️
src/biosequence/printing.jl 79.48% <0.00%> (+5.12%) ⬆️
src/geneticcode.jl 86.60% <0.00%> (+14.13%) ⬆️
src/bit-manipulation/bitpar-compiler.jl 93.38% <0.00%> (+22.54%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jakobnissen jakobnissen merged commit 459ea2a into BioJulia:master Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant