feature(ui-ux): redesign token breakdown #2787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add condition to display locked percentage for loan token
Fetch loan token once on balance screen Display locked token only if value is non-zero
Remove e2e for available amount percent and value
And not added with locked amount
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Code Climate has analyzed commit b753fc7 and detected 0 issues on this pull request. View more on Code Climate. |
Missing Translations ReportThe following translations are missing for this pull request. {
"missingLanguageItems": {
"zh-Hans": {
"missingCount": 0,
"labels": {},
"totalCount": 1111,
"allLabels": "{}"
},
"zh-Hant": {
"missingCount": 0,
"labels": {},
"totalCount": 1111,
"allLabels": "{}"
},
"fr": {
"missingCount": 0,
"labels": {},
"totalCount": 1111,
"allLabels": "{}"
},
"es": {
"missingCount": 0,
"labels": {},
"totalCount": 1111,
"allLabels": "{}"
},
"it": {
"missingCount": 0,
"labels": {},
"totalCount": 1111,
"allLabels": "{}"
}
},
"totalMissingCount": 0
} |
✅ Deploy Preview for mobile-wallet-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #2787 +/- ##
===========================================
+ Coverage 64.82% 81.85% +17.02%
===========================================
Files 359 359
Lines 7932 7923 -9
Branches 2018 2012 -6
===========================================
+ Hits 5142 6485 +1343
+ Misses 2782 1418 -1364
- Partials 8 20 +12
Continue to review full report at Codecov.
|
|
Build preview for DeFiChain Wallet is ready! Built with commit c2050e6 https://expo.io/@defichain/wallet?release-channel=pr-preview-2787 |
To enter dfi token detail screen first
Fix alignment in mobile view
Use 8dp if token value is <=0.1
In DFI balance card details section
kyleleow
requested review from
thedoublejay,
izzycsy,
fullstackninja864,
pierregee and
chloezxyy
as code owners
thedoublejay
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind feature
What this PR does / why we need it:
Which issue(s) does this PR fixes?:
Fixes #2615
Additional comments?:
Developer Checklist: