Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruben patches #3

Merged
merged 17 commits into from
Mar 23, 2015
Merged

Ruben patches #3

merged 17 commits into from
Mar 23, 2015

Conversation

rubensayshi
Copy link
Member

No description provided.

rubensayshi and others added 17 commits March 17, 2015 10:56
@rubensayshi
fixed vout and sequence not being flipped
fe8810e
@rubensayshi
add sort arg to sort pubKeys when creating multisig
4108792
@rubensayshi
moved classifier constants to the correct interface
0b8a785
@rubensayshi
add derivePath method to HDKey
3d9a89c
@rubensayshi
ignore custom phpunit.xml
5c70514
@rubensayshi
add Serializable abstract class to provide basic methods using getBuffer
565478a
@rubensayshi
changed Address classes so that we can decode an address
4fb171c
@rubensayshi
better docblocks for Crypto\Hash
d52cbcf
@rubensayshi
use interfaces instead of classes for type hints
e0e9c5d
@rubensayshi
no need to bin2hex, Crypto\Hash will take care of that
89c4aba
@rubensayshi
fixed *CollectionSerializer classes not using the passed in *Serializer
7bb56d4
@rubensayshi
network presets
e39fb1c
@rubensayshi
phpcs
293d7b2
@rubensayshi
Merge branch 'ruben-patches' into ruben-patches2
3fb7e26 
Conflicts:
	src/Bitcoin/Address/Address.php
	src/Bitcoin/Address/AddressFactory.php
	src/Bitcoin/Address/PayToPubKeyHashAddress.php
	src/Bitcoin/Address/ScriptHashAddress.php
	src/Bitcoin/Bitcoin.php
	src/Bitcoin/Block/Block.php
	src/Bitcoin/Block/BlockHeader.php
	src/Bitcoin/Key/HierarchicalKey.php
	src/Bitcoin/Key/Key.php
	src/Bitcoin/Script/OutputScriptFactory.php
	src/Bitcoin/Script/Script.php
	src/Bitcoin/Script/ScriptFactory.php
	src/Bitcoin/Serializer/Transaction/TransactionInputCollectionSerializer.php
	src/Bitcoin/Serializer/Transaction/TransactionOutputCollectionSerializer.php
	src/Bitcoin/Signature/Signature.php
	src/Bitcoin/Transaction/Transaction.php
	src/Bitcoin/Transaction/TransactionCollection.php
	src/Bitcoin/Transaction/TransactionInput.php
	src/Bitcoin/Transaction/TransactionInputCollection.php
	src/Bitcoin/Transaction/TransactionOutput.php
	src/Bitcoin/Transaction/TransactionOutputCollection.php
	tests/BitcoinTest.php
	tests/Key/HierarchicalKeyTest.php
	tests/Key/PrivateKeyTest.php
	tests/Network/NetworkTest.php
	tests/Transaction/TransactionTest.php
@rubensayshi
Fix phpdoc and tests
0ad51f5 
Conflicts:

	src/Bitcoin/Key/HierarchicalKeyFactory.php
	src/Bitcoin/Network/NetworkFactory.php
	src/Bitcoin/Serializer/Key/HierarchicalKey/HexExtendedKeySerializer.php
	tests/Key/HierarchicalKeyTest.php
@rubensayshi
phpcs fix
8400c71
@rubensayshi
Update readme, fix tests
d2ee7b7 
Conflicts:

	tests/Network/NetworkTest.php
@rubensayshi rubensayshi mentioned this pull request Mar 23, 2015
Closed
afk11 added a commit that referenced this pull request Mar 23, 2015
@afk11
Merge pull request #3 from Bit-Wasp/ruben-patches2
58b5242 
Ruben patches
@afk11 afk11 merged commit 58b5242 into master Mar 23, 2015
@afk11 afk11 deleted the ruben-patches2 branch March 29, 2015 21:49
This was referenced May 3, 2017
Closed
Closed
afk11 pushed a commit to afk11/bitcoin-php that referenced this pull request Sep 6, 2017
add testcase from ln rfc Bit-Wasp#3 - to_local output
708e4c4
afk11 pushed a commit to afk11/bitcoin-php that referenced this pull request Sep 6, 2017
lightning rfc Bit-Wasp#3 received htclc outputs
2ef9588
afk11 pushed a commit that referenced this pull request Sep 6, 2017
@afk11
add testcase from ln rfc #3 - to_local output
b25c66e
afk11 pushed a commit that referenced this pull request Sep 6, 2017
@afk11
lightning rfc #3 received htclc outputs
efaba0f
@wartw wartw mentioned this pull request Mar 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rubensayshi @afk11