build: fix sanitizers #1585
Merged
build: fix sanitizers #1585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickeZ
force-pushed
the
maint/sanitizers
branch
2 times, most recently
from
8a718ec to
56189d5
Compare
The recommended way to enable sanitizers nowadays is to add `-fsanitize=*` as a compiler and linking flags. Also fix some warnings and remove some targets from "all" to speed up builds. Bumping macosx version to 11 since that seems to be necessary for asan to work. Add CI check to verify that address santizier is turned on for unit tests
NickeZ
force-pushed
the
maint/sanitizers
branch
from
56189d5 to
a33c43b
Compare
benma
approved these changes
Sep 11, 2025
yeah, when building the unit tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recommended way to enable sanitizers nowadays is to add
-fsanitize=*as a compiler and linking flags.