fix live device counter check in u2f unit tests #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglasbakkum
force-pushed
the
180311/u2fcounterlivetest
branch
from
165d7ef to
7e98a8a
Compare
douglasbakkum
force-pushed
the
180311/u2fcounterlivetest
branch
from
7e98a8a to
af9eaf1
Compare
douglasbakkum
pushed a commit
that referenced
this pull request
Mar 11, 2018
af9eaf1 fix live device counter check in u2f unit tests (djb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix: The unit testing API calls for the standard HWW interface, used to update the U2F counter value, were being run in simulation only for both simulation and live testing.