Skip to content

Conversation

andyyan162
Copy link
Contributor

Ticket: BTC-2566

  • Add ListTransactionsResponse codec with nextBatchPrevId for pagination
  • Update TransactionQuery to include prevId parameter for cursor navigation
  • Enhance listTransactions method to return paginated response
  • Add comprehensive JSDoc documentation explaining pagination patterns
  • Update example to handle new response format
  • Add thorough test coverage for pagination scenarios

This implementation follows on-chain transaction pagination patterns with:

  • Composite cursor using (date, id) for stable ordering
  • prevId parameter for continuation tokens
  • nextBatchPrevId response field for next page navigation
  • Full backward compatibility for existing usage

@andyyan162 andyyan162 requested a review from a team as a code owner September 26, 2025 18:06
Copy link
Contributor

@davidkaplanbitgo davidkaplanbitgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with few nits

@andyyan162 andyyan162 changed the title feat(lightning): implement pagination for lighting transactions feat(abstract lightning): implemented pagination for lighting transactions Sep 26, 2025
@andyyan162 andyyan162 force-pushed the feature/BTC-2566-lightning-pagination branch 2 times, most recently from ec9bbff to 6e7914b Compare September 26, 2025 19:35
@andyyan162 andyyan162 changed the title feat(abstract lightning): implemented pagination for lighting transactions feat: implemented pagination for lighting transactions Sep 26, 2025
@andyyan162 andyyan162 force-pushed the feature/BTC-2566-lightning-pagination branch 2 times, most recently from dcee6bb to 884eba9 Compare September 29, 2025 16:46
@andyyan162 andyyan162 requested review from a team as code owners September 29, 2025 17:51
@andyyan162 andyyan162 force-pushed the feature/BTC-2566-lightning-pagination branch 2 times, most recently from 07d8b3c to 884eba9 Compare September 29, 2025 18:10
…ransactions

Ticket: BTC-2566

- Add prevId parameter to TransactionQuery for cursor-based pagination
- Add nextBatchPrevId to ListTransactionsResponse for pagination continuation
- Update lightning wallet interface to return paginated response format
- Add comprehensive JSDoc documentation for pagination cursor pattern
- Update example to use new destructured response format
- Add comprehensive test coverage for pagination scenarios
@andyyan162 andyyan162 force-pushed the feature/BTC-2566-lightning-pagination branch from 884eba9 to ce9b735 Compare September 29, 2025 18:31
@andyyan162 andyyan162 merged commit 2a677c2 into master Sep 29, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants