-
Notifications
You must be signed in to change notification settings - Fork 300
feat(sdk-coin-canton): added key pair generation & test #7140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
9f44e16
to
9aa34bb
Compare
e87dc8b
to
2d03522
Compare
"@swc/core-darwin-arm64@1.13.5": | ||
version "1.13.5" | ||
resolved "https://registry.npmjs.org/@swc/core-darwin-arm64/-/core-darwin-arm64-1.13.5.tgz#7638c073946f9297753ed9a2eb198d07b2336a24" | ||
integrity sha512-lKNv7SujeXvKn16gvQqUQI5DdyY8v7xcoO3k06/FJbHJS90zEwZdQiMNRiqpYw/orU543tPaWgz7cIYWhbopiQ== | ||
|
||
"@swc/core-darwin-x64@1.13.5": | ||
version "1.13.5" | ||
resolved "https://registry.npmjs.org/@swc/core-darwin-x64/-/core-darwin-x64-1.13.5.tgz#18061167378f0fb285e17818494bc6c89dd07551" | ||
integrity sha512-ILd38Fg/w23vHb0yVjlWvQBoE37ZJTdlLHa8LRCFDdX4WKfnVBiblsCU9ar4QTMNdeTBEX9iUF4IrbNWhaF1Ng== | ||
|
||
"@swc/core-linux-arm-gnueabihf@1.13.5": | ||
version "1.13.5" | ||
resolved "https://registry.npmjs.org/@swc/core-linux-arm-gnueabihf/-/core-linux-arm-gnueabihf-1.13.5.tgz#4c8062bd598049b5b9b0beb762e075e76b4c23c3" | ||
integrity sha512-Q6eS3Pt8GLkXxqz9TAw+AUk9HpVJt8Uzm54MvPsqp2yuGmY0/sNaPPNVqctCX9fu/Nu8eaWUen0si6iEiCsazQ== | ||
|
||
"@swc/core-linux-arm64-gnu@1.13.5": | ||
version "1.13.5" | ||
resolved "https://registry.npmjs.org/@swc/core-linux-arm64-gnu/-/core-linux-arm64-gnu-1.13.5.tgz#7222d321197ea9304e387933e87d775849fc1ae6" | ||
integrity sha512-aNDfeN+9af+y+M2MYfxCzCy/VDq7Z5YIbMqRI739o8Ganz6ST+27kjQFd8Y/57JN/hcnUEa9xqdS3XY7WaVtSw== | ||
|
||
"@swc/core-linux-arm64-musl@1.13.5": | ||
version "1.13.5" | ||
resolved "https://registry.npmjs.org/@swc/core-linux-arm64-musl/-/core-linux-arm64-musl-1.13.5.tgz#51e7958deaf37edc212bd9dc0ea1476f151d2bea" | ||
integrity sha512-9+ZxFN5GJag4CnYnq6apKTnnezpfJhCumyz0504/JbHLo+Ue+ZtJnf3RhyA9W9TINtLE0bC4hKpWi8ZKoETyOQ== | ||
|
||
"@swc/core-linux-x64-gnu@1.13.5": | ||
version "1.13.5" | ||
resolved "https://registry.npmjs.org/@swc/core-linux-x64-gnu/-/core-linux-x64-gnu-1.13.5.tgz#3476beab93ab03e92844d955ca9d9289aa4a5993" | ||
integrity sha512-WD530qvHrki8Ywt/PloKUjaRKgstQqNGvmZl54g06kA+hqtSE2FTG9gngXr3UJxYu/cNAjJYiBifm7+w4nbHbA== | ||
|
||
"@swc/core-linux-x64-musl@1.13.5": | ||
version "1.13.5" | ||
resolved "https://registry.npmjs.org/@swc/core-linux-x64-musl/-/core-linux-x64-musl-1.13.5.tgz#f4934b1e77e2a297909bb3ab977836205c36e5e0" | ||
integrity sha512-Luj8y4OFYx4DHNQTWjdIuKTq2f5k6uSXICqx+FSabnXptaOBAbJHNbHT/06JZh6NRUouaf0mYXN0mcsqvkhd7Q== | ||
|
||
"@swc/core-win32-arm64-msvc@1.13.5": | ||
version "1.13.5" | ||
resolved "https://registry.npmjs.org/@swc/core-win32-arm64-msvc/-/core-win32-arm64-msvc-1.13.5.tgz#5084c107435cfc82d4d901bfb388dc319d38a236" | ||
integrity sha512-cZ6UpumhF9SDJvv4DA2fo9WIzlNFuKSkZpZmPG1c+4PFSEMy5DFOjBSllCvnqihCabzXzpn6ykCwBmHpy31vQw== | ||
|
||
"@swc/core-win32-ia32-msvc@1.13.5": | ||
version "1.13.5" | ||
resolved "https://registry.npmjs.org/@swc/core-win32-ia32-msvc/-/core-win32-ia32-msvc-1.13.5.tgz#f8b2e28bc51b30467e316ed736a130c1324b9880" | ||
integrity sha512-C5Yi/xIikrFUzZcyGj9L3RpKljFvKiDMtyDzPKzlsDrKIw2EYY+bF88gB6oGY5RGmv4DAX8dbnpRAqgFD0FMEw== | ||
|
||
"@swc/core-win32-x64-msvc@1.13.5": | ||
version "1.13.5" | ||
resolved "https://registry.npmjs.org/@swc/core-win32-x64-msvc/-/core-win32-x64-msvc-1.13.5.tgz#13883cf3c63bf11b787e28dcdf75ca0cc49efa83" | ||
integrity sha512-YrKdMVxbYmlfybCSbRtrilc6UA8GF5aPmGKBdPvjrarvsmf4i7ZHGCEnLtfOMd3Lwbs2WUZq3WdMbozYeLU93Q== | ||
|
||
"@swc/core@^1.13.3": | ||
version "1.13.5" | ||
resolved "https://registry.npmjs.org/@swc/core/-/core-1.13.5.tgz#93874b831d3bd121560e6fcd688972b7fc7baa26" | ||
integrity sha512-WezcBo8a0Dg2rnR82zhwoR6aRNxeTGfK5QCD6TQ+kg3xx/zNT02s/0o+81h/3zhvFSB24NtqEr8FTw88O5W/JQ== | ||
dependencies: | ||
"@swc/counter" "^0.1.3" | ||
"@swc/types" "^0.1.24" | ||
optionalDependencies: | ||
"@swc/core-darwin-arm64" "1.13.5" | ||
"@swc/core-darwin-x64" "1.13.5" | ||
"@swc/core-linux-arm-gnueabihf" "1.13.5" | ||
"@swc/core-linux-arm64-gnu" "1.13.5" | ||
"@swc/core-linux-arm64-musl" "1.13.5" | ||
"@swc/core-linux-x64-gnu" "1.13.5" | ||
"@swc/core-linux-x64-musl" "1.13.5" | ||
"@swc/core-win32-arm64-msvc" "1.13.5" | ||
"@swc/core-win32-ia32-msvc" "1.13.5" | ||
"@swc/core-win32-x64-msvc" "1.13.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is an absolutely massive dependency footprint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed
"dependencies": { | ||
"@bitgo/sdk-core": "^36.10.1", | ||
"@bitgo/statics": "^58.2.0", | ||
"@canton-network/wallet-sdk": "^0.9.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a way to implement this without introducing a large dependency like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it will be very hard to proceed without this dependency, we will be using multiple utility functions of the canton wallet sdk in our build flow. One of the main usecase is in calculating the hash locally after the build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have created this PR: #7183 - will try to implement all the required static functions of the canton sdk locally
767b1be
to
c2e5729
Compare
Closing this, we are going ahead without the canton sdk dependencies. Ref: #7183 |
Ticket: COIN-5838