Skip to content

fix: update fullname of binance smart chain and bnb token #7142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2025
Merged

fix: update fullname of binance smart chain and bnb token #7142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions modules/sdk-coin-bsc/test/unit/bsc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { Bsc, Tbsc } from '../../src/index';

const bitgo: TestBitGoAPI = TestBitGo.decorate(BitGoAPI, { env: 'test' });

describe('Binance Smart Chain', function () {
describe('Native BNB', function () {
before(function () {
bitgo.safeRegister('bsc', Bsc.createInstance);
bitgo.safeRegister('tbsc', Tbsc.createInstance);
Expand All @@ -21,7 +21,7 @@ describe('Binance Smart Chain', function () {
bsc.should.be.an.instanceof(Bsc);
bsc.getChain().should.equal('bsc');
bsc.getFamily().should.equal('bsc');
bsc.getFullName().should.equal('Binance Smart Chain');
bsc.getFullName().should.equal('Native BNB');
bsc.getBaseFactor().should.equal(1e18);
bsc.supportsTss().should.equal(true);
bsc.allowsAccountConsolidations().should.equal(true);
Expand All @@ -33,7 +33,7 @@ describe('Binance Smart Chain', function () {
tbsc.should.be.an.instanceof(Tbsc);
tbsc.getChain().should.equal('tbsc');
tbsc.getFamily().should.equal('bsc');
tbsc.getFullName().should.equal('Testnet Binance Smart Chain');
tbsc.getFullName().should.equal('Testnet Native BNB');
tbsc.getBaseFactor().should.equal(1e18);
tbsc.supportsTss().should.equal(true);
tbsc.allowsAccountConsolidations().should.equal(true);
Expand Down
4 changes: 2 additions & 2 deletions modules/statics/src/allCoinsAndTokens.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1202,7 +1202,7 @@ export const allCoinsAndTokens = [
account(
'd0d44124-c7e9-4214-96ae-fbc6856ee3c2',
'bsc',
'Binance Smart Chain',
'Native BNB',
Networks.main.bsc,
18,
UnderlyingAsset.BSC,
Expand All @@ -1212,7 +1212,7 @@ export const allCoinsAndTokens = [
account(
'0a205427-f7c9-48a4-a238-c4b33ba6384d',
'tbsc',
'Testnet Binance Smart Chain',
'Testnet Native BNB',
Networks.test.bsc,
18,
UnderlyingAsset.BSC,
Expand Down
2 changes: 1 addition & 1 deletion modules/statics/src/coins/erc20Coins.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -992,7 +992,7 @@ export const erc20Coins = [
erc20(
'462e1878-68eb-4c2b-9346-cee992195cdc',
'bnb',
'BNB Token',
'BNB Token (ETH Network)',
18,
'0xb8c77482e45f1f44de1745f52c74426c631bdd52',
UnderlyingAsset.BNB
Expand Down
11 changes: 2 additions & 9 deletions modules/statics/src/coins/ofcCoins.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,14 +104,7 @@ export const ofcCoins = [
ofc('5958e6e9-c6d7-4372-8d1d-c681f595c481', 'ofchash', 'Provenance', 9, UnderlyingAsset.HASH, CoinKind.CRYPTO),
ofc('4616eb4e-9244-449c-a503-02cb2d715b2c', 'ofcsei', 'Sei', 6, UnderlyingAsset.SEI, CoinKind.CRYPTO),
ofc('50a00889-47d2-44b5-8dc8-1fb3b4f47b86', 'ofczeta', 'Zeta', 18, UnderlyingAsset.ZETA, CoinKind.CRYPTO),
ofc(
'03df4c0c-12be-4b24-b3c3-c59be198711b',
'ofcbsc',
'Binance Smart Chain',
18,
UnderlyingAsset.BSC,
CoinKind.CRYPTO
),
ofc('03df4c0c-12be-4b24-b3c3-c59be198711b', 'ofcbsc', 'Native BNB', 18, UnderlyingAsset.BSC, CoinKind.CRYPTO),
ofc('7b79bc25-5497-4350-b961-4bbed2bea994', 'ofcsui', 'Sui', 9, UnderlyingAsset.SUI, CoinKind.CRYPTO),
ofc('31bae66e-a135-42f9-b9d3-1623ab9c7ecc', 'ofctrx', 'Tron', 6, UnderlyingAsset.TRX, CoinKind.CRYPTO),
ofc('dbbceebe-9096-4d7b-ae9e-31eb8a3dc5ca', 'ofcsol', 'Solana', 9, UnderlyingAsset.SOL, CoinKind.CRYPTO),
Expand Down Expand Up @@ -491,7 +484,7 @@ export const ofcCoins = [
tofc(
'52e600bb-b006-452b-9f82-f81c20d0168d',
'ofctbsc',
'Testnet Binance Smart Chain',
'Testnet Native BNB',
18,
UnderlyingAsset.BSC,
CoinKind.CRYPTO
Expand Down
2 changes: 1 addition & 1 deletion modules/statics/src/coins/ofcErc20Coins.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export const ofcErc20Coins = [
ofcerc20('ae72248b-19fb-4736-9430-caf68615a751', 'ofcbal', 'Balancer', 18, UnderlyingAsset.BAL),
ofcerc20('8541eeed-0478-45fe-bff9-4bcc63ef3f67', 'ofcbico', 'Biconomy', 18, UnderlyingAsset.BICO),
ofcerc20('48e33478-36b0-4332-a792-6b4d629c2376', 'ofcbit', 'BitDAO', 18, UnderlyingAsset.BIT),
ofcerc20('4bc691c4-dcdd-4b78-be96-1e87269c3caf', 'ofcbnb', 'BNB Token', 18, UnderlyingAsset.BNB),
ofcerc20('4bc691c4-dcdd-4b78-be96-1e87269c3caf', 'ofcbnb', 'BNB Token (ETH Network)', 18, UnderlyingAsset.BNB),
ofcerc20('7a76184c-b4b2-4c87-81bc-0c496c605488', 'ofcbnt', 'Bancor', 18, UnderlyingAsset.BNT),
ofcerc20('f142074d-8d94-442b-a0e3-3f09c98acaeb', 'ofcbtrst', 'Braintrust', 18, UnderlyingAsset.BTRST),
ofcerc20('779e9fa5-e4f2-4c74-947a-5b5df61e66df', 'ofcbusd', 'Binance USD', 18, UnderlyingAsset.BUSD, undefined, [
Expand Down