feat: add optional name param to httpRequest #863
Conversation
|
🎉 This PR is included in version @api-ts/express-wrapper@1.0.28 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @api-ts/typed-express-router@1.1.8 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
| @@ -1,4 +1,4 @@ | |||
| import { pipe } from 'fp-ts/pipeable'; | |||
| import { pipe } from 'fp-ts/function'; | |||
There was a problem hiding this comment.
issue: This line is actually a breaking change! @ad-world, can you please open a PR to import from pipeable instead?
The issue is the io-ts-http package manifest advertises compatibility with fp-ts version 2.0.0 or higher1, while pipe was only added to the function module in fp-ts v2.6.32. It is important to import from pipeable (even though marked as deprecated) because that import does exist from v2.0.03. This guarantees even when consumers are using an fp-ts version between 2.0.0 and 2.6.3, the pipe import can still be found.
Footnotes
|
🎉 This PR is included in version @api-ts/superagent-wrapper@1.2.3 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @api-ts/io-ts-http@3.1.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @api-ts/openapi-generator@4.28.1 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
DX-634
This ticket adds an optional name parameter to the httpRequest function. Now, if a decode fails (and the httpRequest has a name), the name can be used for logging / debugging purposes to improve inspection, rather than only seeing the expected schema and trying to figure out the request from there.