Skip to content

Don't explode header params #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2025
Merged

Don't explode header params #989

merged 1 commit into from
Jan 17, 2025

Conversation

bitgopatmcl
Copy link
Contributor

The trick used to handle query params for request unions does not work for headers, so this changes it to just use the first set of available headers. This can be improved, but fixes the broken behavior.

@bitgopatmcl bitgopatmcl requested a review from a team as a code owner January 17, 2025 16:48
@bitgopatmcl bitgopatmcl marked this pull request as draft January 17, 2025 16:52
@bitgopatmcl bitgopatmcl marked this pull request as ready for review January 17, 2025 16:58
@ericcrosson-bitgo ericcrosson-bitgo merged commit 45f5fcb into master Jan 17, 2025
6 checks passed
@ericcrosson-bitgo ericcrosson-bitgo deleted the dont-explode-headers branch January 17, 2025 17:32
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version @api-ts/openapi-generator@5.5.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version @api-ts/typed-express-router@2.0.0-beta.1 🎉

The release is available on npm package (@beta dist-tag)

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version @api-ts/express-wrapper@2.0.0-beta.1 🎉

The release is available on npm package (@beta dist-tag)

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version @api-ts/typed-express-router@1.1.14 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version @api-ts/express-wrapper@1.0.34 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version @api-ts/superagent-wrapper@1.3.4 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericcrosson-bitgo ericcrosson-bitgo ericcrosson-bitgo approved these changes

Assignees
No one assigned
Labels
released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bitgopatmcl @ericcrosson-bitgo