Merge forks331 into master #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
examples, use public broadcast endpoints
also some of the urls were broken
The links were redirecting to 404 - I've modified them so they adhere to the beginning of the respective Segwit unit tests.
Found some more links that were displaced by the Segwit unit tests and fixed them
Fixes for issue 901 continued
Add tests for scripts.witness*.input and fixes
BIP32/secp256k1/keyPair preparation
tests: txb for TxBuilder, Tx for Transaction
…nity-check increase max feerate sanity check from 1000 to 2500
Adds an extra parameter to fromTransaction, which tells the library to expect a value property to be added on each txin which uses bitcoin cash's sighashtype
|
I've tested this manually on v1 btc and v2 btc + bch and transaction creation/broadcasting went as expected. |
brandonblack
pushed a commit
that referenced
this pull request
Mar 18, 2022
feat: add stricter validation for taproot addresses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings with it support for bitcoin-cash and bitcoin gold.
I pulled the https://github.com/dabura667/bitcoinjs-lib/tree/forks331/ branch in locally and merged it with
master. I was thinking we just use theforks331as our main codebase and publish that, but BitGo devs have made commits to the master branch in the past so we want to preserve those.If there are future hardforks that require additional bitcoinjs-lib signing logic, we can either write them ourselves and merge them into our
masterbranch, or if someone like dabura667 writes the logic for us we can update our localforks331branch from upstream and merge that intomaster.