Cleanup #10
Merged
Cleanup #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazy_static seems to be used nowhere.
Use the hex crate that is already bundled with rust-bitcoin instead of the `hex` crate that hasn't been updated in 4 years.
bincode is used exclusively in unit tests
We don't use this feature anywhere.
Serde should be optional in case downstream crates don't need it.
|
We might want to bump the version number because of the new serde feature flag. |
Yes let's do that. |
lucidLuckylee
approved these changes
Mar 6, 2025
|
I bumped both version numbers for consistency. I don't expect the macro crate to be used independently from the main crate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cleaned up the dependencies and fixed some clippy issues. Feel free to point out if I removed parts that were actually used somewhere.