Refactor: Remove if checks and stack analyzer #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manishbista28
pushed a commit
to alpenlabs/rust-bitcoin-script
that referenced
this pull request
Feb 22, 2025
* Test the analyzer * Fix: Stack change calculation * Disable op_if checks for now * Add debug info for OP_PICK and OP_ROLL * Change how we add stack_hints * Use same analyzer to carry over last_constant * No longer split scripts with a stack hint * Remove print * Remove unnecessary func and print last_constant * Panic at Debug * Print the latest executed opcode * Fix pushbytes debug_position * Use parent identifier for empty debug identifiers * No longer print last_opcode * Print script when throwing op_roll/pick error * Remove debug script print * Write analyzed chunk stats to file * Print stack inputs only * Implement a hard stack_limit for chunks * Implement a hard stack limit with analyzer * Print script function names in error message * Fix debug_position being off * Add function to check final state of stackstatus --------- Co-authored-by: Lukas <lucidLuckylee@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They will be eventually replaced with a more capable analyzer