-
Notifications
You must be signed in to change notification settings - Fork 112
Add underline to high contrast text when prefers-contrast is active #1141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for bitcoin-design-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@GBKS - You mentioned the need for this in a previous thread. |
Awesome, thanks for tackling this one. Just one question, why the 2px thickness instead of 1px? |
That was just to make it stand out a bit more for someone who is already using enhanced contrast accessibility settings. 1px should work here too. |
Changed to a 1 px thickness and offset for a tighter, cleaner, look and feel.
Thanks, it was actually just a question out of curiosity. I'm happy to go with either option, just let me know which one you think works better. |
Let's go with the the second, more subtle approach since it is not required to make it stand out so much. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking care of this. Very much appreciate it.
Adds an underline to high contrast link text in the guide body when
prefers-contrast
is active as set by the user in their OS settings.As per previous discussion: #1015 (comment)