Created artwork for Sending Bitcoin page (fix for #207) #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # _compress_images_cache.yml # guide/payments/send.md
|
Looks awesome. To fulfill my duty as chief-image-nitpicker, I do have to point out that the image file names should have the "@2x" suffice for the retina version, and no suffix for the regular one, and that the social preview image should be a separate image with 1200x630px size. |
|
I should have read the manual. Fixed. |
|
Closes #207 |
|
@sbddesign this one just needs a conflict resolve, then we can merge. |
|
Resolved the conflict on Stephen's behalf, let's get this beauty IN! |
GBKS
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.