Skip to content

[Bug] Use toFixed #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2025
Merged

[Bug] Use toFixed #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ce1d5b
Use toFixed
bh2smith Feb 1, 2025
e270247
Fix Test
bh2smith Feb 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/agent-sdk/src/evm/safe.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ export async function flatSafeBalances(
}

// TODO(bh2smith): Move this into Zerion SDK
function zerionToTokenBalance(userToken: UserToken): TokenBalance {
export function zerionToTokenBalance(userToken: UserToken): TokenBalance {
const { meta, balances } = userToken;
return {
tokenAddress: meta.contractAddress || null,
Expand All @@ -138,7 +138,7 @@ function zerionToTokenBalance(userToken: UserToken): TokenBalance {
decimals: meta.decimals,
logoUri: meta.tokenIcon || "",
},
balance: parseUnits(balances.balance.toString(), meta.decimals).toString(), // Convert number to string
balance: parseUnits(balances.balance.toFixed(), meta.decimals).toString(), // Convert number to string
fiatBalance: balances.usdBalance.toFixed(2),
fiatConversion: (balances.price || 0).toFixed(2),
};
Expand Down
37 changes: 36 additions & 1 deletion packages/agent-sdk/tests/evm/safe.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
import { zeroAddress } from "viem";
import { getSafeBalances, flatSafeBalances } from "../../src";
import {
getSafeBalances,
flatSafeBalances,
zerionToTokenBalance,
} from "../../src";
describe("getSafeBalances", () => {
const originalWarn = console.warn;

Expand All @@ -17,6 +21,37 @@ describe("getSafeBalances", () => {
await expect(getSafeBalances(999, zeroAddress)).resolves.toEqual([]);
});

it("should throw error for unsupported chain ID", () => {
expect(
zerionToTokenBalance({
chain: {
chainName: "",
},
balances: {
balance: 2.22047152096e-16,
usdBalance: 0,
},
meta: {
name: "",
symbol: "",
decimals: 0,
isSpam: false,
},
}),
).toEqual({
balance: "0",
fiatBalance: "0.00",
fiatConversion: "0.00",
token: {
decimals: 0,
logoUri: "",
name: "",
symbol: "",
},
tokenAddress: null,
});
});

it.skip("should fetch balances for Arbitrum", async () => {
const result = await getSafeBalances(
42161,
Expand Down