Optional Viem Client #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bh2smith
commented
Jul 14, 2025
| getTokenSymbol(chainId, address), | ||
| getTokenName(chainId, address), | ||
| ]); | ||
| const [decimals, symbol, name] = await rpc.multicall({ |
There was a problem hiding this comment.
Here... without constructor args...
There was a problem hiding this comment.
I see, think the difference is this is explicitly using it v.s. the other one is a passive optimization that automatically batches multiple contract reads if they occur.
This was erroring btw but 90% sure it was from chain object missing so the client was unsure of the multicall contract deployment address
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing users to pass their own client.
Would be better if they just passed an RPC. Better solution coming soon.