Fixes A11y test errors #673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjaymiller
commented
May 13, 2025
| patterns: | ||
| - name: "Global Defaults" | ||
| pattern: "blog./*.md" # match ALL `.md` files | ||
| pattern: "_posts./*.md" # match ALL `.md` files |
There was a problem hiding this comment.
our blog posts are at _posts
kjaymiller
commented
May 13, 2025
| script.id = "commitchange-script"; | ||
| script.src = "https://us.commitchange.com/js/donate-button.v2.js"; | ||
|
|
||
| script.onload = function () { |
There was a problem hiding this comment.
This wasn't executing before the A11y testing so this was moved out of this script
kjaymiller
commented
May 13, 2025
| title: BAOVOLA Marie Anna Added to BPD Council | ||
| date: 2025-04-28 | ||
| author: Jay Miller | ||
| layout: post |
kjaymiller
force-pushed
the
push-ptzptpuumxoy
branch
from
efdbb82 to
2bd4518
Compare
kjaymiller
commented
May 13, 2025
There was a problem hiding this comment.
Because the a11y testing is a part of pytest we don't need to versions of this. We test a11y everytime we run pytest
TimOsahenru
approved these changes
May 13, 2025
kjaymiller
added a commit
that referenced
this pull request
May 16, 2025
This reverts commit 7a0dcfd.
kjaymiller
added a commit
that referenced
this pull request
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link 🔗:
Type of Change
Description 📋
Fixes the accessibility errors causing things to fail.
What: Provide an overview of the issue this PR addresses. Explain the context and background information.
Why: Describe why the changes are being made. Highlight key updates, new features, or bug fixes.
How: Explain how these changes will affect the project or end-users.
Checklist ✅
pre-commit run --allAdditional Notes & Screenshots
Add any additional notes or comments that might be helpful for the reviewers.