Skip to content

Use correct event hyperlinks in the footer #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2025

Conversation

dragid10
Copy link
Member

@dragid10 dragid10 commented Aug 19, 2025

(Fixing an issue with my last PR)

Issue Links 🔗:

Issues: Fixes #725, Fixes #733

Type of Change

  • Bug fix 🐞
  • New feature/page
  • Documentation update
  • Other

Description 📋

Really all the information from #731, but I typo'd the footers.

Checklist ✅

  • Followed the Code of Conduct and Contribution Guide
  • Ran pre-commit run --all
  • All tests pass locally
  • Added tests (if applicable)
  • Documentation updated (if applicable)

Additional Notes & Screenshots

image image

Add any additional notes or comments that might be helpful for the reviewers.
Updated steps to deploy the site locally:

  1. Create your virtual environment
  2. Install the deps: python -m pip install -e .
  3. Build the site: render-engine build
  4. Navigate to built site directory: cd output
  5. Start up an http server: python3 -m http.server 8000
  6. Check out your changes in the browser: http://localhost:8000

@dragid10 dragid10 requested a review from kjaymiller August 19, 2025 12:38
@dragid10 dragid10 self-assigned this Aug 19, 2025
@kjaymiller
Copy link
Contributor

This is good and approved but perhaps you can hit #733 with it as well

@dragid10
Copy link
Member Author

This is good and approved but perhaps you can hit #733 with it as well

I actually think I will

All the links (excpet `bpd-events`) now end with `.html`. The reason this doesn't happen for `bpd-events` is because it is a collection that utilizes a base template, but has its data populated from the `events.json`
@dragid10 dragid10 requested a review from kjaymiller August 20, 2025 02:54
@dragid10
Copy link
Member Author

@kjaymiller got the other footer links fixed! 👌🏿
bpd-events doesn't have a specific html page to use because its a collection that pulls data from the events.json. So it seems to just use the default.html template but changes the data on the fly. (This is mostly me explaining it for anyone else that happens to come across this PR)

@dragid10 dragid10 merged commit f39d398 into BlackPythonDevs:gh-pages Aug 20, 2025
1 of 2 checks passed
@dragid10 dragid10 deleted the fix-footer-pt2 branch August 20, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Footer quick links are incorrect... events tag in footer is outdated
2 participants