[pull] main from helm:main #1

pull · 2021-07-22T20:47:26Z

See Commits and Changes for more details.

Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

commit-lint · 2021-07-22T20:47:31Z

Chore

deps: bump github.com/BurntSushi/toml from 0.4.1 to 1.0.0 (583c4ac)

Code Refactoring

use os.ReadDir for lightweight directory reading (e12f357)

Contributors

sabre1041, scottrigby, mattfarina, dependabot[bot], runyontr, dperaza4dustbit, matthiasfehr, Juneezee, hickeyma, jdolitsky

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

@Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
@Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
@Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
@Commit-Lint merge disable will desactivate merge dependabot PR
@Commit-Lint review will approve dependabot PR
@Commit-Lint stop review will stop approve dependabot PR

mergify · 2022-04-15T13:29:03Z

@pull-request-quantifier[bot] is not allowed to run commands

commit-lint · 2022-11-08T20:54:14Z

Documentation

add an example for using the upgrade command with existing values (e35bf1f)

Oci

Add flag --plain-http to enable working with HTTP registries (2538b92)
add tests for plain HTTP and insecure HTTPS registries (6defb96)

Chore

deps: bump github.com/opencontainers/runc from 1.1.4 to 1.1.5 (2bfc367)
deps: bump oras.land/oras-go from 1.2.2 to 1.2.3 (d8caa67)
deps: bump github.com/rubenv/sql-migrate from 1.3.1 to 1.5.1 (d0febd5)
fix a typo in manager.go (15e6066)

Contributors

joejulian, mih-kopylov, mattfarina, josegonzalez, aryan9600, dependabot[bot], wujunwei, yardenshoham, sabre1041, gjenkins8, jmhbnz

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

@Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
@Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
@Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
@Commit-Lint merge disable will desactivate merge dependabot PR
@Commit-Lint review will approve dependabot PR
@Commit-Lint stop review will stop approve dependabot PR

chore: HTTPGetter add default timeout

…codeql-action-2.21.4 chore(deps): bump github/codeql-action from 2.21.3 to 2.21.4

Fix helm may identify achieve of the application/x-gzip as application/vnd.ms-fontobject

Bumps [github.com/containerd/containerd](https://github.com/containerd/containerd) from 1.7.0 to 1.7.3. - [Release notes](https://github.com/containerd/containerd/releases) - [Changelog](https://github.com/containerd/containerd/blob/main/RELEASES.md) - [Commits](containerd/containerd@v1.7.0...v1.7.3) --- updated-dependencies: - dependency-name: github.com/containerd/containerd dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

…github-action

…containerd/containerd-1.7.3 chore(deps): bump github.com/containerd/containerd from 1.7.0 to 1.7.3

Signed-off-by: ithrael <wh01096045@gmail.com>

Bumps [github.com/rubenv/sql-migrate](https://github.com/rubenv/sql-migrate) from 1.5.1 to 1.5.2. - [Commits](rubenv/sql-migrate@v1.5.1...v1.5.2) --- updated-dependencies: - dependency-name: github.com/rubenv/sql-migrate dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

…logs of each hook Signed-off-by: lubingtan <lubingtan@126.com>

…ll-upgrade

Adds labels support for install and upgrade commands

fix(helm): fix GetPodLogs, the hooks should be sorted before get the logs of each hook

Fail if could not retrieve latest release tag from github

github: add Asset Transparency action for GitHub releases

…rubenv/sql-migrate-1.5.2 chore(deps): bump github.com/rubenv/sql-migrate from 1.5.1 to 1.5.2

Signed-off-by: Tim Chaplin <tim.chaplin@datadoghq.com>

…cy-shadowing

Bumps [golang.org/x/term](https://github.com/golang/term) from 0.10.0 to 0.11.0. - [Commits](golang/term@v0.10.0...v0.11.0) --- updated-dependencies: - dependency-name: golang.org/x/term dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

pull-request-quantifier-deprecated · 2024-03-22T14:36:38Z

This PR has 12928 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Extra Large
Size       : +9558 -3370
Percentile : 100%

Total files changed: 438

Change summary by file extension:
.sh : +10 -61
.yml : +154 -66
.yaml : +488 -4
.gitignore : +2 -0
.md : +23 -12
.go : +7851 -3030
.txt : +560 -62
.json : +43 -0
.mod : +157 -38
.helmignore : +23 -0
.crt : +80 -17
.key : +81 -25
.pem : +27 -27
Makefile : +20 -16
OWNERS : +12 -4
cmd/helm/testdata/password : +1 -0
scripts/get : +7 -3
scripts/get-helm-3 : +19 -5

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

pull-request-quantifier-deprecated · 2024-03-22T14:38:08Z

This PR has 12928 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Extra Large
Size       : +9558 -3370
Percentile : 100%

Total files changed: 438

Change summary by file extension:
.sh : +10 -61
.yml : +154 -66
.yaml : +488 -4
.gitignore : +2 -0
.md : +23 -12
.go : +7851 -3030
.txt : +560 -62
.json : +43 -0
.mod : +157 -38
.helmignore : +23 -0
.crt : +80 -17
.key : +81 -25
.pem : +27 -27
Makefile : +20 -16
OWNERS : +12 -4
cmd/helm/testdata/password : +1 -0
scripts/get : +7 -3
scripts/get-helm-3 : +19 -5

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

pull-request-quantifier-deprecated · 2024-03-22T14:39:55Z

This PR has 12928 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Extra Large
Size       : +9558 -3370
Percentile : 100%

Total files changed: 438

Change summary by file extension:
.sh : +10 -61
.yml : +154 -66
.yaml : +488 -4
.gitignore : +2 -0
.md : +23 -12
.go : +7851 -3030
.txt : +560 -62
.json : +43 -0
.mod : +157 -38
.helmignore : +23 -0
.crt : +80 -17
.key : +81 -25
.pem : +27 -27
Makefile : +20 -16
OWNERS : +12 -4
cmd/helm/testdata/password : +1 -0
scripts/get : +7 -3
scripts/get-helm-3 : +19 -5

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

Signed-off-by: deterclosed <fliter@outlook.com>

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.24.7 to 3.24.10. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@3ab4101...4355270) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

…codeql-action-3.24.10 chore(deps): bump github/codeql-action from 3.24.7 to 3.24.10

pull-request-quantifier-deprecated · 2024-04-06T11:30:02Z

This PR has 12928 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Extra Large
Size       : +9558 -3370
Percentile : 100%

Total files changed: 438

Change summary by file extension:
.sh : +10 -61
.yml : +154 -66
.yaml : +488 -4
.gitignore : +2 -0
.md : +23 -12
.go : +7851 -3030
.txt : +560 -62
.json : +43 -0
.mod : +157 -38
.helmignore : +23 -0
.crt : +80 -17
.key : +81 -25
.pem : +27 -27
Makefile : +20 -16
OWNERS : +12 -4
cmd/helm/testdata/password : +1 -0
scripts/get : +7 -3
scripts/get-helm-3 : +19 -5

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

…docker/docker-24.0.9incompatible chore(deps): bump github.com/docker/docker from 24.0.7+incompatible to 24.0.9+incompatible

pull-request-quantifier-deprecated · 2024-04-10T17:25:12Z

This PR has 12928 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Extra Large
Size       : +9558 -3370
Percentile : 100%

Total files changed: 438

Change summary by file extension:
.sh : +10 -61
.yml : +154 -66
.yaml : +488 -4
.gitignore : +2 -0
.md : +23 -12
.go : +7851 -3030
.txt : +560 -62
.json : +43 -0
.mod : +157 -38
.helmignore : +23 -0
.crt : +80 -17
.key : +81 -25
.pem : +27 -27
Makefile : +20 -16
OWNERS : +12 -4
cmd/helm/testdata/password : +1 -0
scripts/get : +7 -3
scripts/get-helm-3 : +19 -5

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

…ng.org/protobuf-1.33.0 chore(deps): bump google.golang.org/protobuf from 1.31.0 to 1.33.0

pull-request-quantifier-deprecated · 2024-04-10T17:41:44Z

This PR has 12928 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Extra Large
Size       : +9558 -3370
Percentile : 100%

Total files changed: 438

Change summary by file extension:
.sh : +10 -61
.yml : +154 -66
.yaml : +488 -4
.gitignore : +2 -0
.md : +23 -12
.go : +7851 -3030
.txt : +560 -62
.json : +43 -0
.mod : +157 -38
.helmignore : +23 -0
.crt : +80 -17
.key : +81 -25
.pem : +27 -27
Makefile : +20 -16
OWNERS : +12 -4
cmd/helm/testdata/password : +1 -0
scripts/get : +7 -3
scripts/get-helm-3 : +19 -5

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

chore: remove repetitive words

pull-request-quantifier-deprecated · 2024-04-10T18:01:34Z

This PR has 12928 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Extra Large
Size       : +9558 -3370
Percentile : 100%

Total files changed: 438

Change summary by file extension:
.sh : +10 -61
.yml : +154 -66
.yaml : +488 -4
.gitignore : +2 -0
.md : +23 -12
.go : +7851 -3030
.txt : +560 -62
.json : +43 -0
.mod : +157 -38
.helmignore : +23 -0
.crt : +80 -17
.key : +81 -25
.pem : +27 -27
Makefile : +20 -16
OWNERS : +12 -4
cmd/helm/testdata/password : +1 -0
scripts/get : +7 -3
scripts/get-helm-3 : +19 -5

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

Correcting linting errors

pull-request-quantifier-deprecated · 2024-04-10T18:05:02Z

This PR has 13150 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Extra Large
Size       : +9669 -3481
Percentile : 100%

Total files changed: 456

Change summary by file extension:
.sh : +10 -61
.yml : +154 -66
.yaml : +488 -4
.gitignore : +2 -0
.md : +23 -12
.go : +7962 -3141
.txt : +560 -62
.json : +43 -0
.mod : +157 -38
.helmignore : +23 -0
.crt : +80 -17
.key : +81 -25
.pem : +27 -27
Makefile : +20 -16
OWNERS : +12 -4
cmd/helm/testdata/password : +1 -0
scripts/get : +7 -3
scripts/get-helm-3 : +19 -5

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

fix: reinstall previously uninstalled chart with --keep-history

pull-request-quantifier-deprecated · 2024-04-10T18:17:45Z

This PR has 13169 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Extra Large
Size       : +9687 -3482
Percentile : 100%

Total files changed: 457

Change summary by file extension:
.sh : +10 -61
.yml : +154 -66
.yaml : +488 -4
.gitignore : +2 -0
.md : +23 -12
.go : +7973 -3142
.txt : +567 -62
.json : +43 -0
.mod : +157 -38
.helmignore : +23 -0
.crt : +80 -17
.key : +81 -25
.pem : +27 -27
Makefile : +20 -16
OWNERS : +12 -4
cmd/helm/testdata/password : +1 -0
scripts/get : +7 -3
scripts/get-helm-3 : +19 -5

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.17.0 to 0.23.0. - [Commits](golang/net@v0.17.0...v0.23.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

…2880) The ca.crt had to be regenerated because there was no ca.key. Added new ca.key so that going forward only the certs need to be updated. Signed-off-by: Dirk Müller <dirk@dmllr.de>

Signed-off-by: Calvin Krist <calvin.krist@yahoo.com>

12124: Fix namespace on kubeconfig error

Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5.0.0 to 5.0.1. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@0c52d54...cdcb360) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

…x/net-0.23.0 chore(deps): bump golang.org/x/net from 0.17.0 to 0.23.0

Update testdata PKI with keys that have validity until 3393 (closes #12880)

bump version to 3.14

…/setup-go-5.0.1 chore(deps): bump actions/setup-go from 5.0.0 to 5.0.1

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.24.10 to 3.25.4. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@4355270...ccf74c9) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: Matt Farina <matt.farina@suse.com>

Updating to k8s 1.30

…codeql-action-3.25.4 chore(deps): bump github/codeql-action from 3.24.10 to 3.25.4

pull-request-quantifier-deprecated bot added the Large label Jul 22, 2021

pull bot added ⤵️ pull and removed Large labels Jul 22, 2021

pull-request-quantifier-deprecated bot added the Large label Jul 27, 2021

pull-request-quantifier-deprecated bot added Extra Large and removed Large labels Aug 19, 2021

joejulian and others added 21 commits August 17, 2023 08:41

Merge pull request #12203 from 0xff-dev/main

a749b66

chore: HTTPGetter add default timeout

Merge pull request #12303 from helm/dependabot/github_actions/github/…

428c5d5

…codeql-action-2.21.4 chore(deps): bump github/codeql-action from 2.21.3 to 2.21.4

Merge pull request #12278 from heijian123/main

f9e03f1

Fix helm may identify achieve of the application/x-gzip as application/vnd.ms-fontobject

Merge remote-tracking branch 'upstream/main' into asset-transparency-…

7aeac9c

…github-action

Merge pull request #12256 from helm/dependabot/go_modules/github.com/…

b2b2145

…containerd/containerd-1.7.3 chore(deps): bump github.com/containerd/containerd from 1.7.0 to 1.7.3

fix: helm rollback err tips

db9460c

Signed-off-by: ithrael <wh01096045@gmail.com>

add rollback unit test

0688046

Signed-off-by: ithrael <wh01096045@gmail.com>

add blank

0eb3df6

Signed-off-by: ithrael <wh01096045@gmail.com>

remove blank

ee1cbed

Signed-off-by: ithrael <wh01096045@gmail.com>

fix(helm): fix GetPodLogs, the hooks should be sorted before get the …

4e5e68d

…logs of each hook Signed-off-by: lubingtan <lubingtan@126.com>

Merge remote-tracking branch 'upstream/main' into add-labels-to-insta…

4ff7d90

…ll-upgrade

Merge pull request #10533 from dm3ch/add-labels-to-install-upgrade

a0831e2

Adds labels support for install and upgrade commands

Merge pull request #12321 from LuBingtan/dev

b6c679e

fix(helm): fix GetPodLogs, the hooks should be sorted before get the logs of each hook

Merge pull request #11031 from shoce/patch-1

acb2ca4

Fail if could not retrieve latest release tag from github

Merge pull request #8697 from philips/asset-transparency-github-action

030646d

github: add Asset Transparency action for GitHub releases

Merge pull request #12318 from helm/dependabot/go_modules/github.com/…

1db97a5

…rubenv/sql-migrate-1.5.2 chore(deps): bump github.com/rubenv/sql-migrate from 1.5.1 to 1.5.2

Use labels instead of selectorLabels for pod labels

479be0c

Signed-off-by: Tim Chaplin <tim.chaplin@datadoghq.com>

Merge remote-tracking branch 'upstream/main' into #9169/lint-dependen…

126333c

…cy-shadowing

deterclosed and others added 3 commits March 23, 2024 14:02

chore: remove repetitive words

dd37787

Signed-off-by: deterclosed <fliter@outlook.com>

Merge pull request #12927 from helm/dependabot/github_actions/github/…

e5e3fac

…codeql-action-3.24.10 chore(deps): bump github/codeql-action from 3.24.7 to 3.24.10

Merge pull request #12899 from helm/dependabot/go_modules/github.com/…

97c1651

…docker/docker-24.0.9incompatible chore(deps): bump github.com/docker/docker from 24.0.7+incompatible to 24.0.9+incompatible

Merge pull request #12878 from helm/dependabot/go_modules/google.gola…

47167ae

…ng.org/protobuf-1.33.0 chore(deps): bump google.golang.org/protobuf from 1.31.0 to 1.33.0

Merge pull request #12905 from deterclosed/main

635b8cf

chore: remove repetitive words

Merge pull request #12866 from robertsirc/Correcting-Linting-Errors

a753ee7

Correcting linting errors

Merge pull request #11569 from alex-petrov-vt/iss-11553

14d0c13

fix: reinstall previously uninstalled chart with --keep-history

dependabot bot and others added 13 commits April 19, 2024 12:21

Update testdata PKI with keys that have validity until 3393 (Fixes #1…

1b75d48

…2880) The ca.crt had to be regenerated because there was no ca.key. Added new ca.key so that going forward only the certs need to be updated. Signed-off-by: Dirk Müller <dirk@dmllr.de>

Fix namespace on kubeconfig error

214fb6e

Signed-off-by: Calvin Krist <calvin.krist@yahoo.com>

Merge pull request #12979 from CalvinKrist/fix-namespace-on-kube-error

c6beb16

12124: Fix namespace on kubeconfig error

Merge pull request #12966 from helm/dependabot/go_modules/golang.org/…

1df0064

…x/net-0.23.0 chore(deps): bump golang.org/x/net from 0.17.0 to 0.23.0

Merge pull request #12971 from dirkmueller/cert_extended_range

cf823d4

Update testdata PKI with keys that have validity until 3393 (closes #12880)

Merge pull request #12701 from mattfarina/bump-version-3.14

7b70fdf

bump version to 3.14

Merge pull request #12999 from helm/dependabot/github_actions/actions…

518c692

…/setup-go-5.0.1 chore(deps): bump actions/setup-go from 5.0.0 to 5.0.1

Updating to k8s 1.30

d209b9b

Signed-off-by: Matt Farina <matt.farina@suse.com>

Merge pull request #13021 from mattfarina/bump-k8s-1.30

2d85884

Updating to k8s 1.30

Merge pull request #13018 from helm/dependabot/github_actions/github/…

d36ee15

…codeql-action-3.25.4 chore(deps): bump github/codeql-action from 3.24.10 to 3.25.4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[pull] main from helm:main #1

[pull] main from helm:main #1

pull bot commented Jul 22, 2021 •

edited

commit-lint bot commented Jul 22, 2021 •

edited

mergify bot commented Apr 15, 2022

commit-lint bot commented Nov 8, 2022 •

edited

pull-request-quantifier-deprecated bot commented Mar 22, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

pull-request-quantifier-deprecated bot commented Mar 22, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

pull-request-quantifier-deprecated bot commented Mar 22, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

pull-request-quantifier-deprecated bot commented Apr 6, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

pull-request-quantifier-deprecated bot commented Apr 10, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

pull-request-quantifier-deprecated bot commented Apr 10, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

pull-request-quantifier-deprecated bot commented Apr 10, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

pull-request-quantifier-deprecated bot commented Apr 10, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

pull-request-quantifier-deprecated bot commented Apr 10, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

[pull] main from helm:main #1

Are you sure you want to change the base?

[pull] main from helm:main #1

Conversation

pull bot commented Jul 22, 2021 • edited

commit-lint bot commented Jul 22, 2021 • edited

Chore

Code Refactoring

Contributors

mergify bot commented Apr 15, 2022

commit-lint bot commented Nov 8, 2022 • edited

Documentation

Oci

Chore

Contributors

pull-request-quantifier-deprecated bot commented Mar 22, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

pull-request-quantifier-deprecated bot commented Mar 22, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

pull-request-quantifier-deprecated bot commented Mar 22, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

pull-request-quantifier-deprecated bot commented Apr 6, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

pull-request-quantifier-deprecated bot commented Apr 10, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

pull-request-quantifier-deprecated bot commented Apr 10, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

pull-request-quantifier-deprecated bot commented Apr 10, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

pull-request-quantifier-deprecated bot commented Apr 10, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

pull-request-quantifier-deprecated bot commented Apr 10, 2024

What can I do to optimize my changes

How to interpret the change counts in git diff output

pull bot commented Jul 22, 2021 •

edited

commit-lint bot commented Jul 22, 2021 •

edited

commit-lint bot commented Nov 8, 2022 •

edited