net: log mud receiver stream read errors #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the `MudReceiver` logic that could potentially read an `Error` result from `self.connection.read(&mut data)` only used the `Ok` result. If there was an error, `data` is set to the empty vec and a higher layer treats the empty data as an EOF initiated disconnect. This commit breaks out the result handling to log a read error with `error!`, and otherwise maintains the existing behaviour: returning an empty vec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
MudReceiverlogic that could potentially read anErrorresult fromself.connection.read(&mut data)only used theOkresult. If there was an error,datais set to the empty vec and a higher layer treats the empty data as an EOF initiated disconnect. The error is dropped.This commit breaks out the result handling to log a read error with
error!, and otherwise maintains the existing behaviour: returning an empty vec.