Update readme #32
Merged
Update readme #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PabloCastellano
force-pushed
the
up-docs
branch
4 times, most recently
from
b9e7f72 to
8805f5f
Compare
0xGabi
requested changes
May 10, 2023
README.md
Outdated
| Using environment variables | ||
|
|
||
| ```bash | ||
| docker run -e BLOBSCAN_API_ENDPOINT=http://blobscan-api:3001 -e BEACON_NODE_RPC=http://beacon:3500 -e EXECUTION_NODE_URL=http://execution:8545 --rm blossomlabs/blobscan-indexer:master |
There was a problem hiding this comment.
I think we are repeating the --rm blossomlabs/blobscan-indexer:master section twice.
There was a problem hiding this comment.
why? these two commands are equivalent ways of running the container with environment variables
There was a problem hiding this comment.
I've added a comment for the second command. Let me know if it's clearer now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Result: https://github.com/Blobscan/blobscan-indexer.rs/blob/up-docs/README.md