Watchlist api #7
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for putting this together! I'm going to verify all of the additions on my machine then, assuming everything is fine, I should be able to merge this and drop it into pip. |
There was a problem hiding this comment.
Be careful with mutable default args. Generally frowned upon
There was a problem hiding this comment.
just reformatted this file. can change this if people think it's necessary but think it is out of scope.
|
Hey, this pull request is from last year... any plan to support the full API? |
|
Closing this as we have officially adopted it here #15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I could not successfully (consistently) test the list api, but it is tested. I did not want to put sleeps in, so I skipped them for now.