This repository was archived by the owner on May 31, 2023. It is now read-only.
Fix passing go-version to setup-go action #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe we want to set `go-version` to the `setup-go` action, and not to the checkout action. I also put the setup-go as the action after the checkout, this is more conventional I believe and we can see it on the example at setup-go's readme: https://github.com/actions/setup-go#readme
|
Thanks! My bad |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe we want to set
go-versionto thesetup-goaction, and not to the checkout action. I also put the setup-go as the action after the checkout, this is more conventional I believe and we can see it on the example at setup-go's readme: https://github.com/actions/setup-go#readme