Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BIP halfagg TODOs #11

Open
1 of 5 tasks
jonasnick opened this issue Sep 10, 2023 · 2 comments
Open
1 of 5 tasks

BIP halfagg TODOs #11

jonasnick opened this issue Sep 10, 2023 · 2 comments

Comments

@jonasnick
Copy link
Contributor

jonasnick commented Sep 10, 2023 •
edited

  • Consider setting z_0 = 1 (actually this is the variant that is proposed in Chen & Zhao)
  • Reconsider maximum number of signatures
  • Add failing verification test vectors that exercise edge cases.
  • Add aggregation test vectors (passing and failing, including edge cases)
  • Test latest version of hacspec (run through checker)
@real-or-random real-or-random mentioned this issue Nov 24, 2023
Merged
@real-or-random
Copy link
Collaborator

real-or-random commented Jan 4, 2024 •
edited

  • Should we allow the "empty" aggsig (n=0)? -- Yes.

@jonasnick
Copy link
Contributor Author

Should we allow the "empty" aggsig (n=0)?

verify_aggregate currently returns true for an "empty" aggsig (s = 0). I think that makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@real-or-random @jonasnick