Use value activate onmount #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change how we add subscription to state changes when using
useValue/useValueSelector. Before the subscription was activated immediately, but it created a problem that you could create a component, not mount it, and the value would still update the node inside (although only if it was not top-level).It also would never unsubscribe, because there was no
unmountevent. This PR adds a subscription only when we actually mount the component, and update the value if it is different.This is a part of #45, but it doesn't close it fully, because
useValueIteratorandtrackValuehave the same issue, I'll address them separately (the PR is already quite big).